From: Catalin Marinas <catalin.marinas@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH 04/10] Modules support for kmemleak
Date: Mon, 10 Jul 2006 23:10:07 +0100 [thread overview]
Message-ID: <20060710221006.5191.28032.stgit@localhost.localdomain> (raw)
In-Reply-To: <20060710220901.5191.66488.stgit@localhost.localdomain>
From: Catalin Marinas <catalin.marinas@arm.com>
This patch handles the kmemleak operations needed for modules loading so
that memory allocations from inside a module are properly tracked.
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
---
kernel/module.c | 41 +++++++++++++++++++++++++++++++++++++++++
1 files changed, 41 insertions(+), 0 deletions(-)
diff --git a/kernel/module.c b/kernel/module.c
index 35e1b1f..3b88c06 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1481,6 +1481,11 @@ static struct module *load_module(void _
unsigned int unusedcrcindex;
unsigned int unusedgplindex;
unsigned int unusedgplcrcindex;
+#ifdef CONFIG_DEBUG_MEMLEAK
+ unsigned int dataindex;
+ unsigned int bssindex;
+ unsigned int mloffindex;
+#endif
struct module *mod;
long err = 0;
void *percpu = NULL, *ptr = NULL; /* Stops spurious gcc warning */
@@ -1577,6 +1582,11 @@ #endif
#ifdef ARCH_UNWIND_SECTION_NAME
unwindex = find_sec(hdr, sechdrs, secstrings, ARCH_UNWIND_SECTION_NAME);
#endif
+#ifdef CONFIG_DEBUG_MEMLEAK
+ dataindex = find_sec(hdr, sechdrs, secstrings, ".data");
+ bssindex = find_sec(hdr, sechdrs, secstrings, ".bss");
+ mloffindex = find_sec(hdr, sechdrs, secstrings, ".init.memleak_offsets");
+#endif
/* Don't keep modinfo section */
sechdrs[infoindex].sh_flags &= ~(unsigned long)SHF_ALLOC;
@@ -1646,6 +1656,10 @@ #endif
/* Do the allocs. */
ptr = module_alloc(mod->core_size);
+ /* the pointer to this block is stored in the module structure
+ * which is inside the block. Just mark it as not being a
+ * leak */
+ memleak_not_leak(ptr);
if (!ptr) {
err = -ENOMEM;
goto free_percpu;
@@ -1654,6 +1668,11 @@ #endif
mod->module_core = ptr;
ptr = module_alloc(mod->init_size);
+ /* the pointer to this block is stored in the module structure
+ * which is inside the block. This block doesn't need to be
+ * scanned as it contains data and code that will be freed
+ * after the module is initialized */
+ memleak_ignore(ptr);
if (!ptr && mod->init_size) {
err = -ENOMEM;
goto free_core;
@@ -1685,6 +1704,28 @@ #endif
/* Module has been moved. */
mod = (void *)sechdrs[modindex].sh_addr;
+#ifdef CONFIG_DEBUG_MEMLEAK
+ if (mloffindex)
+ memleak_insert_aliases((void *)sechdrs[mloffindex].sh_addr,
+ (void *)sechdrs[mloffindex].sh_addr
+ + sechdrs[mloffindex].sh_size);
+
+ /* only scan the sections containing data */
+ memleak_scan_area(mod->module_core,
+ (unsigned long)mod - (unsigned long)mod->module_core,
+ sizeof(struct module));
+ if (dataindex)
+ memleak_scan_area(mod->module_core,
+ sechdrs[dataindex].sh_addr
+ - (unsigned long)mod->module_core,
+ sechdrs[dataindex].sh_size);
+ if (bssindex)
+ memleak_scan_area(mod->module_core,
+ sechdrs[bssindex].sh_addr
+ - (unsigned long)mod->module_core,
+ sechdrs[bssindex].sh_size);
+#endif
+
/* Now we've moved module, initialize linked lists, etc. */
module_unload_init(mod);
next prev parent reply other threads:[~2006-07-10 22:10 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 22:09 [PATCH 00/10] Kernel memory leak detector 0.8 Catalin Marinas
2006-07-10 22:09 ` [PATCH 01/10] Base support for kmemleak Catalin Marinas
2006-07-10 22:09 ` [PATCH 02/10] Some documentation " Catalin Marinas
2006-07-10 22:09 ` [PATCH 03/10] Add the memory allocation/freeing hooks " Catalin Marinas
2006-07-11 6:17 ` Pekka Enberg
2006-07-11 7:59 ` Catalin Marinas
2006-07-10 22:10 ` Catalin Marinas [this message]
2006-07-10 22:10 ` [PATCH 05/10] Add kmemleak support for i386 Catalin Marinas
2006-07-10 22:10 ` [PATCH 06/10] Add kmemleak support for ARM Catalin Marinas
2006-07-10 22:10 ` [PATCH 07/10] Remove some of the kmemleak false positives Catalin Marinas
2006-07-11 6:49 ` Pekka Enberg
2006-07-11 8:18 ` Catalin Marinas
2006-07-10 22:10 ` [PATCH 08/10] Keep the __init functions after initialization Catalin Marinas
2006-07-10 22:10 ` [PATCH 09/10] Simple testing for kmemleak Catalin Marinas
2006-07-10 22:11 ` [PATCH 10/10] Update the MAINTAINERS file " Catalin Marinas
2006-07-11 12:27 ` [PATCH 00/10] Kernel memory leak detector 0.8 Michal Piotrowski
2006-07-11 12:46 ` Michal Piotrowski
2006-07-11 12:51 ` Michal Piotrowski
2006-07-11 13:00 ` Catalin Marinas
2006-07-11 13:09 ` Michal Piotrowski
2006-07-12 9:57 ` Joseph Fannin
2006-07-12 10:38 ` Catalin Marinas
2006-07-12 10:49 ` Michal Piotrowski
2006-07-14 2:22 ` Horst von Brand
2006-07-11 12:56 ` Catalin Marinas
2006-07-11 13:17 ` Michal Piotrowski
2006-07-11 13:28 ` Catalin Marinas
2006-07-11 13:49 ` Michal Piotrowski
2006-07-11 14:02 ` Catalin Marinas
2006-07-11 15:02 ` Michal Piotrowski
2006-07-11 15:44 ` Catalin Marinas
2006-07-11 16:02 ` Michal Piotrowski
2006-07-11 16:31 ` Catalin Marinas
2006-07-11 17:00 ` Michal Piotrowski
2006-07-11 21:54 ` Catalin Marinas
2006-07-12 11:35 ` Michal Piotrowski
2006-07-12 16:17 ` Catalin Marinas
2006-07-12 22:55 ` Michal Piotrowski
2006-07-13 16:35 ` Catalin Marinas
2006-07-13 19:14 ` Michal Piotrowski
2006-07-14 14:53 ` Catalin Marinas
2006-07-12 13:19 ` Michal Piotrowski
2006-07-12 14:37 ` Catalin Marinas
2006-07-12 15:33 ` Michal Piotrowski
2006-07-12 16:12 ` Catalin Marinas
2006-07-12 10:33 ` Catalin Marinas
2006-07-12 18:46 ` Xiaolan Zhang
2006-07-13 18:52 ` Xiaolan Zhang
2006-07-13 19:17 ` Michal Piotrowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060710221006.5191.28032.stgit@localhost.localdomain \
--to=catalin.marinas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox