From: Mike Grundy <grundym@us.ibm.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
Jan Glauber <jan.glauber@de.ibm.com>,
linux-kernel@vger.kernel.org, systemtap@sources.redhat.com,
dwilder@us.ibm.com
Subject: Re: [PATCH] kprobes for s390 architecture
Date: Mon, 10 Jul 2006 18:20:54 -0400 [thread overview]
Message-ID: <20060710222054.GA27908@localhost.localdomain> (raw)
In-Reply-To: <20060710092852.GC9440@osiris.boeblingen.de.ibm.com>
On Mon, Jul 10, 2006 at 11:28:52AM +0200, Heiko Carstens wrote:
> Whitespace :)
d'oh.
> You need a label behind the cs instruction and put that into the __ex_table,
> since the PSW will point to the instruction after cs if it fails.
Yeah, thought that was a nullify not a terminate. d'oh. d'oh.
> Also, on failure this function seems to return -EFAULT >> shift, which
> seems to be wrong.
Yeah. I think just returning the value without the shift would be ok. kprobes
never checks to see if the instruction swap was successful (which seems even
more wrong)
> > +EXPORT_SYMBOL(register_die_notifier);
> > +EXPORT_SYMBOL(unregister_die_notifier);
> _GPL?
Makes sense, but I kept it consistent with the rest of kprobes.
--
Thanks
Mike
=========================================
Michael Grundy - grundym@us.ibm.com
If at first you don't succeed, call in an air strike.
next prev parent reply other threads:[~2006-07-10 22:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060623150344.GL9446@osiris.boeblingen.de.ibm.com>
2006-06-23 22:53 ` [heiko.carstens@de.ibm.com: Re: [PATCH] kprobes for s390 architecture] Michael Grundy
2006-06-23 22:21 ` [PATCH] kprobes for s390 architecture Heiko Carstens
2006-06-24 11:36 ` Heiko Carstens
2006-06-24 12:15 ` Heiko Carstens
2006-06-25 13:31 ` Mike Grundy
2006-06-26 8:09 ` Heiko Carstens
2006-06-26 10:49 ` Mike Grundy
2006-06-26 11:19 ` Heiko Carstens
2006-06-27 15:23 ` Martin Schwidefsky
2006-06-28 5:58 ` Heiko Carstens
2006-07-07 17:23 ` Mike Grundy
2006-07-07 17:25 ` Heiko Carstens
2006-07-08 18:54 ` Mike Grundy
2006-07-08 19:58 ` Mike Grundy
2006-07-10 9:28 ` Heiko Carstens
2006-07-10 22:20 ` Mike Grundy [this message]
2006-07-11 13:54 ` Mike Grundy
2006-07-11 14:13 ` Martin Schwidefsky
2006-06-12 13:15 Mike Grundy
2006-06-12 19:40 ` Martin Schwidefsky
2006-06-21 4:28 ` Mike Grundy
2006-06-21 16:38 ` Martin Schwidefsky
2006-06-21 17:15 ` Mike Grundy
2006-06-27 11:56 ` Martin Schwidefsky
2006-06-21 17:34 ` Mike Grundy
2006-06-22 11:28 ` Jan Glauber
2006-06-22 16:36 ` Mike Grundy
2006-06-23 8:50 ` Jan Glauber
2006-06-23 14:38 ` Heiko Carstens
2006-06-22 1:38 ` Mike Grundy
2006-06-21 9:40 ` Jan Glauber
2006-06-21 16:23 ` Jan Glauber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060710222054.GA27908@localhost.localdomain \
--to=grundym@us.ibm.com \
--cc=dwilder@us.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jan.glauber@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox