From: David Miller <davem@davemloft.net>
To: bos@serpentine.com
Cc: linux-kernel@vger.kernel.org, arjan@infradead.org
Subject: Re: [PATCH] Add memcpy_cachebypass, a copy routine that tries to keep cache pressure down
Date: Tue, 11 Jul 2006 14:57:51 -0700 (PDT) [thread overview]
Message-ID: <20060711.145751.77136364.davem@davemloft.net> (raw)
In-Reply-To: <1152653401.16499.35.camel@chalcedony.pathscale.com>
From: Bryan O'Sullivan <bos@serpentine.com>
Date: Tue, 11 Jul 2006 14:30:01 -0700
> The last time I tried submitting a patch that followed that style (for
> __iowrite_copy*), it got NAKed for propagating preprocessor abuse (Linus
> roundly flamed someone for a similar patch a few weeks before I
> submitted mine), and Andrew suggested that I use the same scheme that
> this patch uses.
>
> So whose instructions do I follow? Yours of today, or Andrew's and
> Linus's of a few months ago?
I didn't realize there was change afoot in this area, sorry.
I was just striving for consistency with current practice.
If Andrew suggested to use weak, that's fine, but it's kind
of erroneous for something like lib/string.c because that
gets built into a library lib.a file, which resolves any
unresolved references.
When the kernel is linked, lib.a implementations only get brought in
if they are not already resolved by definitions present in the other
objects of the kernel image.
Weak makes more sense when dealing with object files, not archives.
next prev parent reply other threads:[~2006-07-11 21:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-11 20:50 [PATCH] Add memcpy_cachebypass, a copy routine that tries to keep cache pressure down Bryan O'Sullivan
2006-07-11 20:56 ` Arjan van de Ven
2006-07-11 20:57 ` David Miller
2006-07-11 21:30 ` Bryan O'Sullivan
2006-07-11 21:57 ` David Miller [this message]
2006-07-11 22:05 ` Bryan O'Sullivan
2006-07-11 22:08 ` David Miller
2006-07-12 8:04 ` Christoph Hellwig
2006-07-11 21:09 ` Randy.Dunlap
2006-07-11 21:35 ` Bryan O'Sullivan
2006-07-11 22:48 ` Randy.Dunlap
2006-07-12 16:15 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060711.145751.77136364.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arjan@infradead.org \
--cc=bos@serpentine.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox