From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: rjw@sisk.pl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 1/2] swsusp: clean up browsing of pfns
Date: Tue, 11 Jul 2006 11:05:26 +0200 [thread overview]
Message-ID: <20060711090525.GE1787@elf.ucw.cz> (raw)
In-Reply-To: <20060711015941.d35f0b7d.akpm@osdl.org>
On Tue 2006-07-11 01:59:41, Andrew Morton wrote:
> On Tue, 11 Jul 2006 10:34:15 +0200
> Pavel Machek <pavel@ucw.cz> wrote:
>
> > Hi!
> >
> > > Clean up some loops over pfns for each zone in snapshot.c: reduce the number
> > > of additions to perform, rework detection of saveable pages and make the code
> > > a bit less difficult to understand, hopefully.
> >
> > Also remove the BUG_ON() so that you can solve Andrew's monster
> > machine problem.
>
> I don't understand your comment. I assume you're adding an explanation for
> the removal of:
>
> - BUG_ON(PageReserved(page) && PageNosave(page));
>
> from saveable_page().
Yes.
> But my emt64 test box is oopsing when touching a hole in the memory-map; it
> isn't going BUG() (any more than usual ;))
Well, it would go BUG() with patch Rafael has somewhere on the
disk. Next step is having pages both reserved and nosave, I believe.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2006-07-11 9:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 20:40 [PATCH -mm 0/2] swsusp cleanups Rafael J. Wysocki
2006-07-10 20:51 ` [PATCH -mm 1/2] swsusp: clean up browsing of pfns Rafael J. Wysocki
2006-07-11 8:34 ` Pavel Machek
2006-07-11 8:59 ` Andrew Morton
2006-07-11 9:05 ` Pavel Machek [this message]
2006-07-11 9:27 ` Rafael J. Wysocki
2006-07-10 21:16 ` [PATCH -mm 2/2] swsusp: struct snapshot_handle cleanup Rafael J. Wysocki
2006-07-11 8:34 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060711090525.GE1787@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox