Re: [PATCH -mm 1/2] swsusp: clean up browsing of pfns

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Tuesday 11 July 2006 11:05, Pavel Machek wrote:
> On Tue 2006-07-11 01:59:41, Andrew Morton wrote:
> > On Tue, 11 Jul 2006 10:34:15 +0200
> > Pavel Machek <pavel@ucw.cz> wrote:
> > 
> > > Hi!
> > > 
> > > > Clean up some loops over pfns for each zone in snapshot.c: reduce the number
> > > > of additions to perform, rework detection of saveable pages and make the code
> > > > a bit less difficult to understand, hopefully.
> > > 
> > > Also remove the BUG_ON() so that you can solve Andrew's monster
> > > machine problem.
> > 
> > I don't understand your comment.  I assume you're adding an explanation for
> > the removal of:
> > 
> > -	BUG_ON(PageReserved(page) && PageNosave(page));
> > 
> > from saveable_page().
> 
> Yes.
> 
> > But my emt64 test box is oopsing when touching a hole in the memory-map; it
> > isn't going BUG() (any more than usual ;))
> 
> Well, it would go BUG() with patch Rafael has somewhere on the
> disk. Next step is having pages both reserved and nosave, I believe.

Yes.

Rafael