* commit '[PATCH] kernel/softirq.c: EXPORT_UNUSED_SYMBOL' @ 2006-07-11 12:01 Christoph Hellwig 2006-07-11 12:12 ` Ingo Molnar 0 siblings, 1 reply; 3+ messages in thread From: Christoph Hellwig @ 2006-07-11 12:01 UTC (permalink / raw) To: akpm, bunk; +Cc: linux-kernel http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=80d6679a62fe45f440d042099d997a42e4e8c59d open_softirq just enables a softirq. The softirq array is statically allocated so to add a new one you would have to patch the kernel. So there's no point to keep this export at all as any user would have to patch the enum in include/linux/interrupt.h anyway. Adrian, care to submit a patch to kill this senseless export entirely? ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: commit '[PATCH] kernel/softirq.c: EXPORT_UNUSED_SYMBOL' 2006-07-11 12:01 commit '[PATCH] kernel/softirq.c: EXPORT_UNUSED_SYMBOL' Christoph Hellwig @ 2006-07-11 12:12 ` Ingo Molnar 2006-07-11 15:19 ` [2.6 patch] unexport open_softirq Adrian Bunk 0 siblings, 1 reply; 3+ messages in thread From: Ingo Molnar @ 2006-07-11 12:12 UTC (permalink / raw) To: Christoph Hellwig; +Cc: akpm, bunk, linux-kernel * Christoph Hellwig <hch@lst.de> wrote: > http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=80d6679a62fe45f440d042099d997a42e4e8c59d > > open_softirq just enables a softirq. The softirq array is statically > allocated so to add a new one you would have to patch the kernel. So > there's no point to keep this export at all as any user would have to > patch the enum in include/linux/interrupt.h anyway. Adrian, care to > submit a patch to kill this senseless export entirely? good point. Acked-by: Ingo Molnar <mingo@elte.hu> Ingo ^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 patch] unexport open_softirq 2006-07-11 12:12 ` Ingo Molnar @ 2006-07-11 15:19 ` Adrian Bunk 0 siblings, 0 replies; 3+ messages in thread From: Adrian Bunk @ 2006-07-11 15:19 UTC (permalink / raw) To: Ingo Molnar; +Cc: Christoph Hellwig, akpm, linux-kernel Christoph Hellwig: open_softirq just enables a softirq. The softirq array is statically allocated so to add a new one you would have to patch the kernel. So there's no point to keep this export at all as any user would have to patch the enum in include/linux/interrupt.h anyway. Signed-off-by: Adrian Bunk <bunk@stusta.de> Acked-by: Ingo Molnar <mingo@elte.hu> --- linux-2.6.18-rc1-mm1-full/kernel/softirq.c.old 2006-07-11 16:50:54.000000000 +0200 +++ linux-2.6.18-rc1-mm1-full/kernel/softirq.c 2006-07-11 16:51:00.000000000 +0200 @@ -311,8 +311,6 @@ softirq_vec[nr].action = action; } -EXPORT_UNUSED_SYMBOL(open_softirq); /* June 2006 */ - /* Tasklets */ struct tasklet_head { ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-07-11 15:19 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2006-07-11 12:01 commit '[PATCH] kernel/softirq.c: EXPORT_UNUSED_SYMBOL' Christoph Hellwig 2006-07-11 12:12 ` Ingo Molnar 2006-07-11 15:19 ` [2.6 patch] unexport open_softirq Adrian Bunk
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox