Re: [klibc 00/43] klibc as a historyless patchset

Milton Miller
2006-06-27T20:38:27Z

On Jun 27, 2006, at 2:12 PM, H. Peter Anvin wrote:

> Milton Miller wrote:
>>> 12-enable-config-klibc-zlib-now-required-to-build-kinit.patch
>> What does this do? No Help, no description, and doesn't do anything
>> in the curreent patch
>
> usr/klibc/Kbuild:
>
> libc-$(CONFIG_KLIBC_ZLIB) += \
> zlib/adler32.o zlib/compress.o zlib/crc32.o zlib/gzio.o \
> zlib/uncompr.o zlib/deflate.o zlib/trees.o zlib/zutil.o \
> zlib/inflate.o zlib/infback.o zlib/inftrees.o zlib/inffast.o
>
> At this point, this is required by kinit, which is why it is not
> possible to disable.

But that file is in 19-, so at this point in the sequence it still
does nothing, and has no help.

Oh, and the files don't exist until 39, so the build breaks from
19 to 39. If you don't want to split the makefile, put that after
39.

>
>>> 13-uml-the-klibc-architecture-is-the-underlying-architecture.patch
>>> 14-remove-in-kernel-nfsroot-code.patch
>>> 15-default-klibcarch--arch.patch
>>> 16-sparc64-transmit-arch-specific-options-to-kinit-via-arch-cmd.patch
>>> 17-sparc32-transfer-arch-specific-options-to-arch-cmd.patch
>> where is x86 and x86_64 ?
>> oh you deleted and did not put that back
>
> That's correct; I went around and talked to both x86 and sparc people,
> and the x86 people uniformly announced rdev support as being obsolete;
> the sparc people, however, continue to rely on being able to get data
> from openprom.

Then it should be a seprate patch, and go though feature-removal or
not on its own merits.

>>> 18-klibc-inkernel-merge-s390s390x-4.patch
>> This patchname is meaningless.
>> The description in the patch is worse.
>> It looks like it should be 18-s390-set-klibcarch
>> Hmm... i didn't find the patch removig usr/Makefile, just adding
>> usr/Kbuild. usr/Kbuild should be a diff against the existing
>> usr/Makefile, whcih can be renamed.
>
> True. Git could work this out.
>
> I have been reluctant to spend too much time on packaging, because
> I've still had the issue of continue to maintain the out-of-tree
> distribution (which includes usr/Kbuild) indefinitely. I need to
> spend some more time scripting.

Because the out-of-tree is trying to be buildable in-tree? Or because
the out-of-tree and in-tree both need to build the same tools?

milton