public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: rdreier@cisco.com
Cc: ralphc@pathscale.com, rolandd@cisco.com,
	openib-general@openib.org, linux-kernel@vger.kernel.org
Subject: Re: Suggestions for how to remove bus_to_virt()
Date: Wed, 12 Jul 2006 17:40:13 -0700 (PDT)	[thread overview]
Message-ID: <20060712.174013.95062313.davem@davemloft.net> (raw)
In-Reply-To: <adar70quzwx.fsf@cisco.com>

From: Roland Dreier <rdreier@cisco.com>
Date: Wed, 12 Jul 2006 17:11:26 -0700

> A cleaner solution would be to make the dma_ API really use the device
> it's passed anyway, and allow drivers to override the standard PCI
> stuff nicely.  But that would be major surgery, I guess.

Clean but expensive, you should not force the rest of the kernel
to eat the cost of something you want to do when it's totally
unnecessary for most other users.

For example, x86 never needs to do anything other than a direct
virt_to_phys translation to produce a DMA address, no matter what
bus the device is on.  It's a single simple integer adjustment
that can be done inline in about 2 or 3 instructions at most.

Once you start allowing overrides then even x86 starts to eat the
stupid costs of dereferencing some kind of device ops method.

That doesn't make any sense, and that's why the DMA API works the way
it does now.  It's a platform or bus operation, not a device one.

If you need device level DMA mapping semantics, create them for your
device type.  This is what USB does, btw.



  reply	other threads:[~2006-07-13  0:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-12 23:29 Suggestions for how to remove bus_to_virt() Ralph Campbell
2006-07-12 23:40 ` David Miller
2006-07-13  0:11 ` Roland Dreier
2006-07-13  0:40   ` David Miller [this message]
2006-07-13  5:46     ` [openib-general] " Muli Ben-Yehuda
2006-07-14 22:27       ` Ralph Campbell
2006-07-14 22:35         ` David Miller
2006-07-14 23:45           ` Ralph Campbell
2006-07-15 13:42             ` Stefan Richter
2006-07-13  7:45     ` Stefan Richter
2006-07-13 16:02     ` Roland Dreier
2006-07-13 16:37       ` Ralph Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060712.174013.95062313.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openib-general@openib.org \
    --cc=ralphc@pathscale.com \
    --cc=rdreier@cisco.com \
    --cc=rolandd@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox