From: Ralf Baechle <ralf@linux-mips.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] lockdep: core, fix rq-lock handling on __ARCH_WANT_UNLOCKED_CTXSW
Date: Wed, 12 Jul 2006 23:42:30 +0100 [thread overview]
Message-ID: <20060712224230.GA7831@linux-mips.org> (raw)
In-Reply-To: <20060712202639.GA7719@elte.hu>
On Wed, Jul 12, 2006 at 10:26:39PM +0200, Ingo Molnar wrote:
> Subject: lockdep: core, fix rq-lock handling on __ARCH_WANT_UNLOCKED_CTXSW
> From: Ingo Molnar <mingo@elte.hu>
>
> on platforms that have __ARCH_WANT_UNLOCKED_CTXSW set and want to
> implement lock validator support there's a bug in rq->lock handling: in
> this case we dont 'carry over' the runqueue lock into another task - but
> still we did a spinlock_release() of it. Fix this by making the
> spinlock_release() in context_switch() dependent on
> !__ARCH_WANT_UNLOCKED_CTXSW.
>
> (Reported by Ralf Baechle on MIPS, which has __ARCH_WANT_UNLOCKED_CTXSW.
> This fixes a lockdep-internal BUG message on such platforms.)
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Tested and works as advertised for me,
Ralf
prev parent reply other threads:[~2006-07-13 11:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-12 20:26 [patch] lockdep: core, fix rq-lock handling on __ARCH_WANT_UNLOCKED_CTXSW Ingo Molnar
2006-07-12 22:42 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060712224230.GA7831@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox