* [PATCH] correct oldconfig for unset choice options
@ 2006-07-13 11:22 Roman Zippel
2006-07-13 14:10 ` Ralf Baechle
0 siblings, 1 reply; 3+ messages in thread
From: Roman Zippel @ 2006-07-13 11:22 UTC (permalink / raw)
To: Andrew Morton, linux-kernel; +Cc: Ralf Baechle
oldconfig currently ignores unset choice options and doesn't ask for them.
Correct the SYMBOL_DEF_USER flag of the choice symbol to be only set if
it's set for all values.
Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
---
scripts/kconfig/confdata.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6-mm/scripts/kconfig/confdata.c
===================================================================
--- linux-2.6-mm.orig/scripts/kconfig/confdata.c 2006-07-12 11:58:59.000000000 +0200
+++ linux-2.6-mm/scripts/kconfig/confdata.c 2006-07-12 12:17:20.000000000 +0200
@@ -357,7 +357,7 @@ int conf_read(const char *name)
for (e = prop->expr; e; e = e->left.expr)
if (e->right.sym->visible != no)
flags &= e->right.sym->flags;
- sym->flags |= flags & SYMBOL_DEF_USER;
+ sym->flags &= flags | ~SYMBOL_DEF_USER;
}
sym_change_count += conf_warnings || conf_unsaved;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] correct oldconfig for unset choice options
2006-07-13 11:22 [PATCH] correct oldconfig for unset choice options Roman Zippel
@ 2006-07-13 14:10 ` Ralf Baechle
2006-07-13 18:33 ` Sam Ravnborg
0 siblings, 1 reply; 3+ messages in thread
From: Ralf Baechle @ 2006-07-13 14:10 UTC (permalink / raw)
To: Roman Zippel; +Cc: Andrew Morton, linux-kernel
On Thu, Jul 13, 2006 at 01:22:38PM +0200, Roman Zippel wrote:
> oldconfig currently ignores unset choice options and doesn't ask for them.
> Correct the SYMBOL_DEF_USER flag of the choice symbol to be only set if
> it's set for all values.
>
> Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
Thanks, this patch solves my problem.
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] correct oldconfig for unset choice options
2006-07-13 14:10 ` Ralf Baechle
@ 2006-07-13 18:33 ` Sam Ravnborg
0 siblings, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2006-07-13 18:33 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Roman Zippel, Andrew Morton, linux-kernel
On Thu, Jul 13, 2006 at 03:10:36PM +0100, Ralf Baechle wrote:
> On Thu, Jul 13, 2006 at 01:22:38PM +0200, Roman Zippel wrote:
>
> > oldconfig currently ignores unset choice options and doesn't ask for them.
> > Correct the SYMBOL_DEF_USER flag of the choice symbol to be only set if
> > it's set for all values.
> >
> > Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
>
> Thanks, this patch solves my problem.
Added to the kbuild.git tree - thanks.
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-07-13 18:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-13 11:22 [PATCH] correct oldconfig for unset choice options Roman Zippel
2006-07-13 14:10 ` Ralf Baechle
2006-07-13 18:33 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox