From: Jeff Dike <jdike@addtoit.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/5] UML - Fix ZONE_HIGHMEM compilation error
Date: Thu, 13 Jul 2006 14:17:55 -0400 [thread overview]
Message-ID: <20060713181754.GA5343@ccure.user-mode-linux.org> (raw)
In-Reply-To: <20060713012421.b59f05d4.akpm@osdl.org>
On Thu, Jul 13, 2006 at 01:24:21AM -0700, Andrew Morton wrote:
> > for(i=0;i<sizeof(zones_size)/sizeof(zones_size[0]);i++)
>
> I spy an ARRAY_SIZE().
Yup, I did an ARRAY_SIZE pass a while ago, but I missed that somehow,
and some grepping shows there are a bunch more.
> Maybe this is an rc1-mm1 fix? Did Christoph's patches break UML, perhaps??
Yes, it's this bit in mmzone.h:
#ifdef CONFIG_HIGHMEM
/*
* A memory area that is only addressable by the kernel through
* mapping portions into its own address space. This is for example
* used by i386 to allow the kernel to address the memory beyond
* 900MB. The kernel will set up special mappings (page
* table entries on i386) for each page that the kernel needs to
* access.
*/
ZONE_HIGHMEM,
#endif
Jeff
prev parent reply other threads:[~2006-07-13 18:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-12 16:39 [PATCH 1/5] UML - Fix ZONE_HIGHMEM compilation error Jeff Dike
2006-07-13 8:24 ` Andrew Morton
2006-07-13 18:17 ` Jeff Dike [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060713181754.GA5343@ccure.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox