public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Roman Zippel <zippel@linux-m68k.org>,
	wookey@debian.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Support DOS line endings
Date: Thu, 13 Jul 2006 12:29:19 -0600	[thread overview]
Message-ID: <20060713182919.GJ1629@parisc-linux.org> (raw)
In-Reply-To: <20060713181825.GA22895@mars.ravnborg.org>

On Thu, Jul 13, 2006 at 08:18:25PM +0200, Sam Ravnborg wrote:
> Negative index'es always make me supsicious.
> I've applied followign patch.
> The fgets thing I have not looked at.

Did you apply the "case '\r'" hunk (around line 269) too?  If not,
it'll spew "unexpected data" error messages for every blank line.

  reply	other threads:[~2006-07-13 18:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-07 17:34 [PATCH] Support DOS line endings Matthew Wilcox
2006-07-07 22:35 ` Sam Ravnborg
2006-07-08  3:23 ` Roman Zippel
2006-07-13 18:18   ` Sam Ravnborg
2006-07-13 18:29     ` Matthew Wilcox [this message]
2006-07-13 18:47     ` Roman Zippel
2006-07-13 19:35       ` Sam Ravnborg
2006-07-13 20:02         ` Matthew Wilcox
2006-07-13 21:07           ` Sam Ravnborg
2006-07-13 21:41             ` Bernd Petrovitsch
2006-07-19 12:02               ` Alistair John Strachan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060713182919.GJ1629@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=wookey@debian.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox