From: Nigel Cunningham <nigel@suspend2.net>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@osdl.org>,
torvalds@osdl.org, linux-kernel@vger.kernel.org,
tglx@timesys.com, linux-pm@lists.osdl.org,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] Rt-tester makes freezing processes fail.
Date: Sat, 15 Jul 2006 08:38:49 +1000 [thread overview]
Message-ID: <200607150838.53591.nigel@suspend2.net> (raw)
In-Reply-To: <200607141017.27832.rjw@sisk.pl>
[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]
Hi.
On Friday 14 July 2006 18:17, Rafael J. Wysocki wrote:
> On Friday 14 July 2006 01:37, Andrew Morton wrote:
> > On Fri, 14 Jul 2006 09:18:43 +1000
> >
> > Nigel Cunningham <nigel@suspend2.net> wrote:
> > > Compiling in the rt-tester currently makes freezing processes fail.
> > > I don't think there's anything wrong with it running during
> > > suspending, so adding PF_NOFREEZE to the flags set seems to be the
> > > right solution.
> > >
> > > Signed-off-by: Nigel Cunningham <nigel@suspend2.net>
> > >
> > > rtmutex-tester.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > diff -ruNp 9971-rt-tester.patch-old/kernel/rtmutex-tester.c
> > > 9971-rt-tester.patch-new/kernel/rtmutex-tester.c ---
> > > 9971-rt-tester.patch-old/kernel/rtmutex-tester.c 2006-07-07
> > > 10:27:46.000000000 +1000 +++
> > > 9971-rt-tester.patch-new/kernel/rtmutex-tester.c 2006-07-14
> > > 07:48:01.000000000 +1000 @@ -259,7 +259,7 @@ static int test_func(void
> > > *data)
> > > struct test_thread_data *td = data;
> > > int ret;
> > >
> > > - current->flags |= PF_MUTEX_TESTER;
> > > + current->flags |= PF_MUTEX_TESTER | PF_NOFREEZE;
> > > allow_signal(SIGHUP);
> > >
> > > for(;;) {
> >
> > I yesterday queued up the below patch. Which approach is most
> > appropriate?
>
> I prefer the one that makes these threads freeze (ie. the Luca's patch).
Ok.
Nigel
--
See http://www.suspend2.net for Howtos, FAQs, mailing
lists, wiki and bugzilla info.
[-- Attachment #2: Type: application/pgp-signature, Size: 191 bytes --]
prev parent reply other threads:[~2006-07-14 22:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-13 23:18 [PATCH] Rt-tester makes freezing processes fail Nigel Cunningham
2006-07-13 23:37 ` Andrew Morton
2006-07-14 8:17 ` Rafael J. Wysocki
2006-07-14 20:33 ` [linux-pm] " Pavel Machek
2006-07-14 22:38 ` Nigel Cunningham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607150838.53591.nigel@suspend2.net \
--to=nigel@suspend2.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=tglx@timesys.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox