* Re: [PATCHSET] 0/15 IO scheduler improvements @ 2006-07-13 20:50 Al Boldi 2006-07-14 7:15 ` Jens Axboe 0 siblings, 1 reply; 9+ messages in thread From: Al Boldi @ 2006-07-13 20:50 UTC (permalink / raw) To: Jens Axboe; +Cc: linux-kernel Jens Axboe wrote: > > This is a continuation of the patches posted yesterday, I continued > to build on them. The patch series does: > > - Move the hash backmerging into the elevator core. > - Move the rbtree handling into the elevator core. > - Abstract the FIFO handling into the elevator core. > - Kill the io scheduler private requests, that require allocation/free > for each request passed through the system. > > The result is a faster elevator core (and faster IO schedulers), with a > nice net reduction of kernel text and code as well. Thanks! Your efforts are much appreciated, as the current situation is a bit awkward. > If you have time, please give this patch series a test spin just to > verify that everything still works for you. Thanks! Do you have a combo-patch against 2.6.17? Thanks! -- Al ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHSET] 0/15 IO scheduler improvements 2006-07-13 20:50 [PATCHSET] 0/15 IO scheduler improvements Al Boldi @ 2006-07-14 7:15 ` Jens Axboe 2006-07-14 19:53 ` Al Boldi 0 siblings, 1 reply; 9+ messages in thread From: Jens Axboe @ 2006-07-14 7:15 UTC (permalink / raw) To: Al Boldi; +Cc: linux-kernel [-- Attachment #1: Type: text/plain, Size: 1238 bytes --] On Thu, Jul 13 2006, Al Boldi wrote: > Jens Axboe wrote: > > > > This is a continuation of the patches posted yesterday, I continued > > to build on them. The patch series does: > > > > - Move the hash backmerging into the elevator core. > > - Move the rbtree handling into the elevator core. > > - Abstract the FIFO handling into the elevator core. > > - Kill the io scheduler private requests, that require allocation/free > > for each request passed through the system. > > > > The result is a faster elevator core (and faster IO schedulers), with a > > nice net reduction of kernel text and code as well. > > Thanks! > > Your efforts are much appreciated, as the current situation is a bit awkward. It's a good step forward, at least. > > If you have time, please give this patch series a test spin just to > > verify that everything still works for you. Thanks! > > Do you have a combo-patch against 2.6.17? Not really, but git let me generate one pretty easily. It has a few select changes outside of the patchset as well, but should be ok. It's not tested though, should work but the rbtree changes needed to be done additionally. If it boots, it should work :-) I've gzip'ed the patch to avoid problems. -- Jens Axboe [-- Attachment #2: iosched-rollup-2.6.17.4.gz --] [-- Type: application/x-gzip, Size: 25948 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHSET] 0/15 IO scheduler improvements 2006-07-14 7:15 ` Jens Axboe @ 2006-07-14 19:53 ` Al Boldi 2006-07-15 11:06 ` Jens Axboe 0 siblings, 1 reply; 9+ messages in thread From: Al Boldi @ 2006-07-14 19:53 UTC (permalink / raw) To: Jens Axboe; +Cc: linux-kernel Jens Axboe wrote: > On Thu, Jul 13 2006, Al Boldi wrote: > > Jens Axboe wrote: > > > This is a continuation of the patches posted yesterday, I continued > > > to build on them. The patch series does: > > > > > > - Move the hash backmerging into the elevator core. > > > - Move the rbtree handling into the elevator core. > > > - Abstract the FIFO handling into the elevator core. > > > - Kill the io scheduler private requests, that require allocation/free > > > for each request passed through the system. > > > > > > The result is a faster elevator core (and faster IO schedulers), with > > > a nice net reduction of kernel text and code as well. > > > > Thanks! > > > > Your efforts are much appreciated, as the current situation is a bit > > awkward. > > It's a good step forward, at least. > > > > If you have time, please give this patch series a test spin just to > > > verify that everything still works for you. Thanks! > > > > Do you have a combo-patch against 2.6.17? > > Not really, but git let me generate one pretty easily. It has a few > select changes outside of the patchset as well, but should be ok. It's > not tested though, should work but the rbtree changes needed to be done > additionally. If it boots, it should work :-) patch applies ok compiles ok panics on boot at elv_rb_del patch -R succeeds with lot's of hunks > I've gzip'ed the patch to avoid problems. Thanks! -- Al ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHSET] 0/15 IO scheduler improvements 2006-07-14 19:53 ` Al Boldi @ 2006-07-15 11:06 ` Jens Axboe 2006-07-15 12:35 ` Al Boldi 0 siblings, 1 reply; 9+ messages in thread From: Jens Axboe @ 2006-07-15 11:06 UTC (permalink / raw) To: Al Boldi; +Cc: linux-kernel [-- Attachment #1: Type: text/plain, Size: 1605 bytes --] On Fri, Jul 14 2006, Al Boldi wrote: > Jens Axboe wrote: > > On Thu, Jul 13 2006, Al Boldi wrote: > > > Jens Axboe wrote: > > > > This is a continuation of the patches posted yesterday, I continued > > > > to build on them. The patch series does: > > > > > > > > - Move the hash backmerging into the elevator core. > > > > - Move the rbtree handling into the elevator core. > > > > - Abstract the FIFO handling into the elevator core. > > > > - Kill the io scheduler private requests, that require allocation/free > > > > for each request passed through the system. > > > > > > > > The result is a faster elevator core (and faster IO schedulers), with > > > > a nice net reduction of kernel text and code as well. > > > > > > Thanks! > > > > > > Your efforts are much appreciated, as the current situation is a bit > > > awkward. > > > > It's a good step forward, at least. > > > > > > If you have time, please give this patch series a test spin just to > > > > verify that everything still works for you. Thanks! > > > > > > Do you have a combo-patch against 2.6.17? > > > > Not really, but git let me generate one pretty easily. It has a few > > select changes outside of the patchset as well, but should be ok. It's > > not tested though, should work but the rbtree changes needed to be done > > additionally. If it boots, it should work :-) > > patch applies ok > compiles ok > panics on boot at elv_rb_del > patch -R succeeds with lot's of hunks So I most likely botched the rbtree conversion, sorry about that. Oh, I think it's a silly reverted condition, can you try this one? -- Jens Axboe [-- Attachment #2: iosched-rollup-2.6.17.4-2.gz --] [-- Type: application/x-gzip, Size: 25948 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHSET] 0/15 IO scheduler improvements 2006-07-15 11:06 ` Jens Axboe @ 2006-07-15 12:35 ` Al Boldi 2006-07-15 17:46 ` Jens Axboe 0 siblings, 1 reply; 9+ messages in thread From: Al Boldi @ 2006-07-15 12:35 UTC (permalink / raw) To: Jens Axboe; +Cc: linux-kernel Jens Axboe wrote: > On Fri, Jul 14 2006, Al Boldi wrote: > > Jens Axboe wrote: > > > On Thu, Jul 13 2006, Al Boldi wrote: > > > > Jens Axboe wrote: > > > > > This is a continuation of the patches posted yesterday, I > > > > > continued to build on them. The patch series does: > > > > > > > > > > - Move the hash backmerging into the elevator core. > > > > > - Move the rbtree handling into the elevator core. > > > > > - Abstract the FIFO handling into the elevator core. > > > > > - Kill the io scheduler private requests, that require > > > > > allocation/free for each request passed through the system. > > > > > > > > > > The result is a faster elevator core (and faster IO schedulers), > > > > > with a nice net reduction of kernel text and code as well. > > > > > > > > Thanks! > > > > > > > > Your efforts are much appreciated, as the current situation is a bit > > > > awkward. > > > > > > It's a good step forward, at least. > > > > > > > > If you have time, please give this patch series a test spin just > > > > > to verify that everything still works for you. Thanks! > > > > > > > > Do you have a combo-patch against 2.6.17? > > > > > > Not really, but git let me generate one pretty easily. It has a few > > > select changes outside of the patchset as well, but should be ok. It's > > > not tested though, should work but the rbtree changes needed to be > > > done additionally. If it boots, it should work :-) > > > > patch applies ok > > compiles ok > > panics on boot at elv_rb_del > > patch -R succeeds with lot's of hunks > > So I most likely botched the rbtree conversion, sorry about that. Oh, I > think it's a silly reverted condition, can you try this one? Thanks! patch applies ok compiles ok boots ok patch -R succeeds with lot's of hunks Tried it anyway, and found an improvement only in cfq, where : echo 512 > /sys/block/hda/queue/max_sectors_kb gives full speed for 5-10 sec then drops to half speed other scheds lock into half speed echo 192 > /sys/block/hda/queue/max_sectors_kb gives full speed for all scheds Thanks! -- Al ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHSET] 0/15 IO scheduler improvements 2006-07-15 12:35 ` Al Boldi @ 2006-07-15 17:46 ` Jens Axboe 2006-07-15 20:27 ` Al Boldi 0 siblings, 1 reply; 9+ messages in thread From: Jens Axboe @ 2006-07-15 17:46 UTC (permalink / raw) To: Al Boldi; +Cc: linux-kernel On Sat, Jul 15 2006, Al Boldi wrote: > Jens Axboe wrote: > > On Fri, Jul 14 2006, Al Boldi wrote: > > > Jens Axboe wrote: > > > > On Thu, Jul 13 2006, Al Boldi wrote: > > > > > Jens Axboe wrote: > > > > > > This is a continuation of the patches posted yesterday, I > > > > > > continued to build on them. The patch series does: > > > > > > > > > > > > - Move the hash backmerging into the elevator core. > > > > > > - Move the rbtree handling into the elevator core. > > > > > > - Abstract the FIFO handling into the elevator core. > > > > > > - Kill the io scheduler private requests, that require > > > > > > allocation/free for each request passed through the system. > > > > > > > > > > > > The result is a faster elevator core (and faster IO schedulers), > > > > > > with a nice net reduction of kernel text and code as well. > > > > > > > > > > Thanks! > > > > > > > > > > Your efforts are much appreciated, as the current situation is a bit > > > > > awkward. > > > > > > > > It's a good step forward, at least. > > > > > > > > > > If you have time, please give this patch series a test spin just > > > > > > to verify that everything still works for you. Thanks! > > > > > > > > > > Do you have a combo-patch against 2.6.17? > > > > > > > > Not really, but git let me generate one pretty easily. It has a few > > > > select changes outside of the patchset as well, but should be ok. It's > > > > not tested though, should work but the rbtree changes needed to be > > > > done additionally. If it boots, it should work :-) > > > > > > patch applies ok > > > compiles ok > > > panics on boot at elv_rb_del > > > patch -R succeeds with lot's of hunks > > > > So I most likely botched the rbtree conversion, sorry about that. Oh, I > > think it's a silly reverted condition, can you try this one? > > Thanks! > > patch applies ok > compiles ok > boots ok > patch -R succeeds with lot's of hunks > > Tried it anyway, and found an improvement only in cfq, where : > echo 512 > /sys/block/hda/queue/max_sectors_kb > gives full speed for 5-10 sec then drops to half speed > other scheds lock into half speed > echo 192 > /sys/block/hda/queue/max_sectors_kb > gives full speed for all scheds Not sure what this all means (full speed for what?) The patchset mainly focuses on optimizing the elevator core and schedulers, it wont give a speedup unless your storage hardware is so fast that you are becoming CPU bound. Since you are applying to 2.6.17, there are some CFQ changes that do introduce behavioural changes. You should download http://brick.kernel.dk/snaps/blktrace-git-20060706102503.tar.gz and build+install it, then do: - blktrace /dev/hda - run shortest test that shows the problem - ctrl-c blktrace tar up the hda.* output from blktrace and put it somewhere where I can reach it and I'll take a look. -- Jens Axboe ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHSET] 0/15 IO scheduler improvements 2006-07-15 17:46 ` Jens Axboe @ 2006-07-15 20:27 ` Al Boldi 2006-07-16 11:26 ` Jens Axboe 0 siblings, 1 reply; 9+ messages in thread From: Al Boldi @ 2006-07-15 20:27 UTC (permalink / raw) To: Jens Axboe; +Cc: linux-kernel Jens Axboe wrote: > On Sat, Jul 15 2006, Al Boldi wrote: > > Jens Axboe wrote: > > > On Fri, Jul 14 2006, Al Boldi wrote: > > > > Jens Axboe wrote: > > > > > On Thu, Jul 13 2006, Al Boldi wrote: > > > > > > Jens Axboe wrote: > > > > > > > This is a continuation of the patches posted yesterday, I > > > > > > > continued to build on them. The patch series does: > > > > > > > > > > > > > > - Move the hash backmerging into the elevator core. > > > > > > > - Move the rbtree handling into the elevator core. > > > > > > > - Abstract the FIFO handling into the elevator core. > > > > > > > - Kill the io scheduler private requests, that require > > > > > > > allocation/free for each request passed through the system. > > > > > > > > > > > > > > The result is a faster elevator core (and faster IO > > > > > > > schedulers), with a nice net reduction of kernel text and code > > > > > > > as well. > > > > > > > > > > > > Thanks! > > > > > > > > > > > > Your efforts are much appreciated, as the current situation is a > > > > > > bit awkward. > > > > > > > > > > It's a good step forward, at least. > > > > > > > > > > > > If you have time, please give this patch series a test spin > > > > > > > just to verify that everything still works for you. Thanks! > > > > > > > > > > > > Do you have a combo-patch against 2.6.17? > > > > > > > > > > Not really, but git let me generate one pretty easily. It has a > > > > > few select changes outside of the patchset as well, but should be > > > > > ok. It's not tested though, should work but the rbtree changes > > > > > needed to be done additionally. If it boots, it should work :-) > > > > > > > > patch applies ok > > > > compiles ok > > > > panics on boot at elv_rb_del > > > > patch -R succeeds with lot's of hunks > > > > > > So I most likely botched the rbtree conversion, sorry about that. Oh, > > > I think it's a silly reverted condition, can you try this one? > > > > Thanks! > > > > patch applies ok > > compiles ok > > boots ok > > patch -R succeeds with lot's of hunks > > > > Tried it anyway, and found an improvement only in cfq, where : > > echo 512 > /sys/block/hda/queue/max_sectors_kb > > gives full speed for 5-10 sec then drops to half speed > > other scheds lock into half speed > > echo 192 > /sys/block/hda/queue/max_sectors_kb > > gives full speed for all scheds > > Not sure what this all means (full speed for what?) full speed = max HD thruput > The patchset mainly > focuses on optimizing the elevator core and schedulers, it wont give a > speedup unless your storage hardware is so fast that you are becoming > CPU bound. Since you are applying to 2.6.17, there are some CFQ changes > that do introduce behavioural changes. > > You should download > > http://brick.kernel.dk/snaps/blktrace-git-20060706102503.tar.gz > > and build+install it, then do: > > - blktrace /dev/hda > - run shortest test that shows the problem > - ctrl-c blktrace > > tar up the hda.* output from blktrace and put it somewhere where I can > reach it and I'll take a look. The output is a bit large, so here is a summary: # echo 192 > /sys/block/hda/queue/max_sectors_kb # cat /dev/hda > /dev/null & # blktrace /dev/hda ( doesn't work; outputs zero trace) # blktrace /dev/hda -w 1 -o - | blkparse -i - > /mnt/nfs/10.1/tmp/hdtrace.cfq.192 3,0 0 1 0.000000000 1200 Q R 927456 + 8 [cat] 3,0 0 2 0.000009840 1200 G R 927456 + 8 [cat] 3,0 0 3 0.000012910 1200 I R 927456 + 8 [cat] 3,0 0 4 0.000017537 1200 Q R 927464 + 8 [cat] (alot of the same) 3,0 0 95 0.000070248 1200 M R 927824 + 8 [cat] 3,0 0 96 0.000070932 1200 Q R 927832 + 8 [cat] 3,0 0 97 0.000071166 1200 M R 927832 + 8 [cat] 3,0 0 98 0.000074233 1200 U R [cat] 2 3,0 0 99 0.000130449 1206 C RB 927072 + 384 [0] 3,0 0 100 0.000179860 1206 D RB 927456 + 384 [blktrace] 3,0 0 101 0.000615062 1200 Q R 927840 + 8 [cat] 3,0 0 102 0.000623531 1200 G R 927840 + 8 [cat] 3,0 0 103 0.000625642 1200 I R 927840 + 8 [cat] 3,0 0 104 0.000630142 1200 Q R 927848 + 8 [cat] 3,0 0 105 0.000631079 1200 M R 927848 + 8 [cat] 3,0 0 106 0.000632693 1200 Q R 927856 + 8 [cat] (alot of the same) 3,0 0 195 0.000687875 1200 M R 928208 + 8 [cat] 3,0 0 196 0.000688709 1200 Q R 928216 + 8 [cat] 3,0 0 197 0.000688916 1200 M R 928216 + 8 [cat] 3,0 0 198 0.000692628 1200 U R [cat] 2 3,0 0 199 0.003454920 0 C RB 927456 + 384 [0] 3,0 0 200 0.003497750 0 D RB 927840 + 384 [swapper] 3,0 0 201 0.003728434 1200 Q R 928224 + 8 [cat] 3,0 0 202 0.003735266 1200 G R 928224 + 8 [cat] 3,0 0 203 0.003737399 1200 I R 928224 + 8 [cat] 3,0 0 204 0.003741069 1200 Q R 928232 + 8 [cat] 3,0 0 205 0.003741640 1200 M R 928232 + 8 [cat] 3,0 0 206 0.003743141 1200 Q R 928240 + 8 [cat] 3,0 0 207 0.003743349 1200 M R 928240 + 8 [cat] 3,0 0 208 0.003744289 1200 Q R 928248 + 8 [cat] 3,0 0 209 0.003744512 1200 M R 928248 + 8 [cat] 3,0 0 210 0.003746801 1200 Q R 928256 + 8 [cat] 3,0 0 211 0.003747006 1200 M R 928256 + 8 [cat] 3,0 0 212 0.003747787 1200 Q R 928264 + 8 [cat] 3,0 0 213 0.003748011 1200 M R 928264 + 8 [cat] 3,0 0 214 0.003748831 1200 Q R 928272 + 8 [cat] (alot of the same) 3,0 0 23893 0.995735914 1200 M R 1019112 + 8 [cat] 3,0 0 23894 0.995736546 1200 Q R 1019120 + 8 [cat] 3,0 0 23895 0.995736754 1200 M R 1019120 + 8 [cat] 3,0 0 23896 0.995737386 1200 Q R 1019128 + 8 [cat] 3,0 0 23897 0.995737593 1200 M R 1019128 + 8 [cat] 3,0 0 23898 0.995738222 1200 Q R 1019136 + 8 [cat] 3,0 0 23899 0.995738433 1200 M R 1019136 + 8 [cat] 3,0 0 23900 0.995739224 1200 Q R 1019144 + 8 [cat] 3,0 0 23901 0.995739432 1200 M R 1019144 + 8 [cat] 3,0 0 23902 0.995740223 1200 Q R 1019152 + 8 [cat] 3,0 0 23903 0.995740434 1200 M R 1019152 + 8 [cat] 3,0 0 23904 0.995741072 1200 Q R 1019160 + 8 [cat] 3,0 0 23905 0.995741280 1200 M R 1019160 + 8 [cat] 3,0 0 23906 0.995742116 1200 Q R 1019168 + 8 [cat] 3,0 0 23907 0.995742324 1200 M R 1019168 + 8 [cat] 3,0 0 23908 0.995742959 1200 Q R 1019176 + 8 [cat] 3,0 0 23909 0.995743170 1200 M R 1019176 + 8 [cat] 3,0 0 23910 0.995744240 1200 Q R 1019184 + 8 [cat] 3,0 0 23911 0.995744447 1200 M R 1019184 + 8 [cat] 3,0 0 23912 0.995745268 1200 Q R 1019192 + 8 [cat] 3,0 0 23913 0.995745475 1200 M R 1019192 + 8 [cat] 3,0 0 23914 0.995746240 1200 Q R 1019200 + 8 [cat] 3,0 0 23915 0.995746448 1200 M R 1019200 + 8 [cat] 3,0 0 23916 0.995747317 1200 Q R 1019208 + 8 [cat] 3,0 0 23917 0.995747524 1200 M R 1019208 + 8 [cat] 3,0 0 23918 0.995748280 1200 Q R 1019216 + 8 [cat] 3,0 0 23919 0.995748490 1200 M R 1019216 + 8 [cat] 3,0 0 23920 0.995749113 1200 Q R 1019224 + 8 [cat] 3,0 0 23921 0.995749320 1200 M R 1019224 + 8 [cat] 3,0 0 23922 0.995751713 1200 U R [cat] 2 CPU0 (3,0): Reads Queued: 11,472, 90,788KiB Writes Queued: 0, 0KiB Read Dispatches: 246, 45,696KiB Write Dispatches: 0, 0KiB Reads Requeued: 0 Writes Requeued: 0 Reads Completed: 246, 45,696KiB Writes Completed: 0, 0KiB Read Merges: 11,225 Write Merges: 0 Read depth: 1 Write depth: 0 IO unplugs: 231 Timer unplugs: 0 Throughput (R/W): 45,925KiB/s / 0KiB/s Events (3,0): 23,922 entries Skips: 0 forward (0 - 0.0%) # echo 512 > /sys/block/hda/queue/max_sectors_kb # cat /dev/hda > /dev/null & # blktrace /dev/hda -w 1 -o - | blkparse -i - > /mnt/nfs/10.1/tmp/hdtrace.cfq.512 3,0 0 1 0.000000000 1221 Q R 2853984 + 8 [cat] 3,0 0 2 0.000008174 1221 G R 2853984 + 8 [cat] 3,0 0 3 0.000010985 1221 I R 2853984 + 8 [cat] 3,0 0 4 0.000014953 1221 Q R 2853992 + 8 [cat] 3,0 0 5 0.000016010 1221 M R 2853992 + 8 [cat] (alot of the same) 3,0 0 94 0.000067068 1221 Q R 2854352 + 8 [cat] 3,0 0 95 0.000067292 1221 M R 2854352 + 8 [cat] 3,0 0 96 0.000068080 1221 Q R 2854360 + 8 [cat] 3,0 0 97 0.000068303 1221 M R 2854360 + 8 [cat] 3,0 0 98 0.000071050 1221 U R [cat] 3 3,0 0 99 0.006566892 1232 C RB 2853600 + 384 [0] 3,0 0 100 0.006623669 1232 D RB 2853984 + 384 [blkparse] 3,0 0 101 0.007166110 1221 Q R 2854368 + 8 [cat] 3,0 0 102 0.007175772 1221 G R 2854368 + 8 [cat] 3,0 0 103 0.007178625 1221 I R 2854368 + 8 [cat] 3,0 0 104 0.007182866 1221 Q R 2854376 + 8 [cat] 3,0 0 105 0.007184072 1221 M R 2854376 + 8 [cat] 3,0 0 106 0.007185670 1221 Q R 2854384 + 8 [cat] 3,0 0 107 0.007185923 1221 M R 2854384 + 8 [cat] 3,0 0 108 0.007186789 1221 Q R 2854392 + 8 [cat] 3,0 0 109 0.007187003 1221 M R 2854392 + 8 [cat] (alot of the same) 3,0 0 193 0.007234987 1221 M R 2854728 + 8 [cat] 3,0 0 194 0.007235671 1221 Q R 2854736 + 8 [cat] 3,0 0 195 0.007235882 1221 M R 2854736 + 8 [cat] 3,0 0 196 0.007236579 1221 Q R 2854744 + 8 [cat] 3,0 0 197 0.007236790 1221 M R 2854744 + 8 [cat] 3,0 0 198 0.007239481 1221 U R [cat] 3 3,0 0 199 0.011350831 0 C RB 2853984 + 384 [0] 3,0 0 200 0.011399039 0 D RB 2854368 + 384 [swapper] 3,0 0 201 0.011647468 1221 Q R 2854752 + 8 [cat] 3,0 0 202 0.011654575 1221 G R 2854752 + 8 [cat] 3,0 0 203 0.011657003 1221 I R 2854752 + 8 [cat] 3,0 0 204 0.011660028 1221 Q R 2854760 + 8 [cat] 3,0 0 205 0.011661105 1221 M R 2854760 + 8 [cat] 3,0 0 206 0.011662431 1221 Q R 2854768 + 8 [cat] 3,0 0 207 0.011662658 1221 M R 2854768 + 8 [cat] 3,0 0 208 0.011663608 1221 Q R 2854776 + 8 [cat] 3,0 0 209 0.011663815 1221 M R 2854776 + 8 [cat] 3,0 0 210 0.011664610 1221 Q R 2854784 + 8 [cat] (alot of the same) 3,0 0 13184 0.990888789 1221 Q R 2904584 + 8 [cat] 3,0 0 13185 0.990889013 1221 M R 2904584 + 8 [cat] 3,0 0 13186 0.990890008 1221 Q R 2904592 + 8 [cat] 3,0 0 13187 0.990890216 1221 M R 2904592 + 8 [cat] 3,0 0 13188 0.990891110 1221 Q R 2904600 + 8 [cat] 3,0 0 13189 0.990891337 1221 M R 2904600 + 8 [cat] 3,0 0 13190 0.990892083 1221 Q R 2904608 + 8 [cat] 3,0 0 13191 0.990892291 1221 M R 2904608 + 8 [cat] 3,0 0 13192 0.990893198 1221 Q R 2904616 + 8 [cat] 3,0 0 13193 0.990893429 1221 M R 2904616 + 8 [cat] 3,0 0 13194 0.990894845 1221 Q R 2904624 + 8 [cat] 3,0 0 13195 0.990895056 1221 M R 2904624 + 8 [cat] 3,0 0 13196 0.990895844 1221 Q R 2904632 + 8 [cat] 3,0 0 13197 0.990896071 1221 M R 2904632 + 8 [cat] 3,0 0 13198 0.990896852 1221 Q R 2904640 + 8 [cat] 3,0 0 13199 0.990897057 1221 M R 2904640 + 8 [cat] 3,0 0 13200 0.990897828 1221 Q R 2904648 + 8 [cat] 3,0 0 13201 0.990898068 1221 M R 2904648 + 8 [cat] 3,0 0 13202 0.990898956 1221 Q R 2904656 + 8 [cat] 3,0 0 13203 0.990899164 1221 M R 2904656 + 8 [cat] 3,0 0 13204 0.990899952 1221 Q R 2904664 + 8 [cat] 3,0 0 13205 0.990900176 1221 M R 2904664 + 8 [cat] 3,0 0 13206 0.990902565 1221 U R [cat] 2 CPU0 (3,0): Reads Queued: 6,336, 50,152KiB Writes Queued: 0, 0KiB Read Dispatches: 133, 25,152KiB Write Dispatches: 1, 4KiB Reads Requeued: 0 Writes Requeued: 0 Reads Completed: 133, 25,152KiB Writes Completed: 1, 4KiB Read Merges: 6,202 Write Merges: 0 Read depth: 1 Write depth: 1 IO unplugs: 130 Timer unplugs: 0 Throughput (R/W): 25,406KiB/s / 4KiB/s Events (3,0): 13,206 entries Skips: 0 forward (0 - 0.0%) Does this help? Thanks! -- Al ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHSET] 0/15 IO scheduler improvements 2006-07-15 20:27 ` Al Boldi @ 2006-07-16 11:26 ` Jens Axboe 0 siblings, 0 replies; 9+ messages in thread From: Jens Axboe @ 2006-07-16 11:26 UTC (permalink / raw) To: Al Boldi; +Cc: linux-kernel On Sat, Jul 15 2006, Al Boldi wrote: > Jens Axboe wrote: > > On Sat, Jul 15 2006, Al Boldi wrote: > > > Jens Axboe wrote: > > > > On Fri, Jul 14 2006, Al Boldi wrote: > > > > > Jens Axboe wrote: > > > > > > On Thu, Jul 13 2006, Al Boldi wrote: > > > > > > > Jens Axboe wrote: > > > > > > > > This is a continuation of the patches posted yesterday, I > > > > > > > > continued to build on them. The patch series does: > > > > > > > > > > > > > > > > - Move the hash backmerging into the elevator core. > > > > > > > > - Move the rbtree handling into the elevator core. > > > > > > > > - Abstract the FIFO handling into the elevator core. > > > > > > > > - Kill the io scheduler private requests, that require > > > > > > > > allocation/free for each request passed through the system. > > > > > > > > > > > > > > > > The result is a faster elevator core (and faster IO > > > > > > > > schedulers), with a nice net reduction of kernel text and code > > > > > > > > as well. > > > > > > > > > > > > > > Thanks! > > > > > > > > > > > > > > Your efforts are much appreciated, as the current situation is a > > > > > > > bit awkward. > > > > > > > > > > > > It's a good step forward, at least. > > > > > > > > > > > > > > If you have time, please give this patch series a test spin > > > > > > > > just to verify that everything still works for you. Thanks! > > > > > > > > > > > > > > Do you have a combo-patch against 2.6.17? > > > > > > > > > > > > Not really, but git let me generate one pretty easily. It has a > > > > > > few select changes outside of the patchset as well, but should be > > > > > > ok. It's not tested though, should work but the rbtree changes > > > > > > needed to be done additionally. If it boots, it should work :-) > > > > > > > > > > patch applies ok > > > > > compiles ok > > > > > panics on boot at elv_rb_del > > > > > patch -R succeeds with lot's of hunks > > > > > > > > So I most likely botched the rbtree conversion, sorry about that. Oh, > > > > I think it's a silly reverted condition, can you try this one? > > > > > > Thanks! > > > > > > patch applies ok > > > compiles ok > > > boots ok > > > patch -R succeeds with lot's of hunks > > > > > > Tried it anyway, and found an improvement only in cfq, where : > > > echo 512 > /sys/block/hda/queue/max_sectors_kb > > > gives full speed for 5-10 sec then drops to half speed > > > other scheds lock into half speed > > > echo 192 > /sys/block/hda/queue/max_sectors_kb > > > gives full speed for all scheds > > > > Not sure what this all means (full speed for what?) > > full speed = max HD thruput Ok, for a cat test I see. This wasn't really obvious from what you wrote, please be more detailed in what tests you are running! > > The patchset mainly > > focuses on optimizing the elevator core and schedulers, it wont give a > > speedup unless your storage hardware is so fast that you are becoming > > CPU bound. Since you are applying to 2.6.17, there are some CFQ changes > > that do introduce behavioural changes. > > > > You should download > > > > http://brick.kernel.dk/snaps/blktrace-git-20060706102503.tar.gz > > > > and build+install it, then do: > > > > - blktrace /dev/hda > > - run shortest test that shows the problem > > - ctrl-c blktrace > > > > tar up the hda.* output from blktrace and put it somewhere where I can > > reach it and I'll take a look. > > The output is a bit large, so here is a summary: > # echo 192 > /sys/block/hda/queue/max_sectors_kb > # cat /dev/hda > /dev/null & > # blktrace /dev/hda ( doesn't work; outputs zero trace) > # blktrace /dev/hda -w 1 -o - | blkparse -i - > > /mnt/nfs/10.1/tmp/hdtrace.cfq.192 I don't see anything wrong in the small excerpts you posted, so can you please just generate a few seconds log from a 192 sector and 512 sector run and put them somewhere where I can download the two? Just do the same sequence of commands you just did, but use -o 192_run or something to keep the files. It's an interesting issue you have seen, I'd like to get to the bottom of it. -- Jens Axboe ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCHSET] 0/15 IO scheduler improvements @ 2006-07-13 12:46 Jens Axboe 0 siblings, 0 replies; 9+ messages in thread From: Jens Axboe @ 2006-07-13 12:46 UTC (permalink / raw) To: linux-kernel Hi, This is a continuation of the patches posted yesterday, I continued to build on them. The patch series does: - Move the hash backmerging into the elevator core. - Move the rbtree handling into the elevator core. - Abstract the FIFO handling into the elevator core. - Kill the io scheduler private requests, that require allocation/free for each request passed through the system. The result is a faster elevator core (and faster IO schedulers), with a nice net reduction of kernel text and code as well. If you have time, please give this patch series a test spin just to verify that everything still works for you. Thanks! block/as-iosched.c | 650 ++++++++++------------------------------------- block/cfq-iosched.c | 498 +++++++++--------------------------- block/deadline-iosched.c | 462 +++++---------------------------- block/elevator.c | 266 +++++++++++++++++-- block/ll_rw_blk.c | 9 include/linux/blkdev.h | 29 +- include/linux/elevator.h | 32 ++ include/linux/rbtree.h | 2 lib/rbtree.c | 6 9 files changed, 649 insertions(+), 1305 deletions(-) -- Jens Axboe ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2006-07-16 11:27 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2006-07-13 20:50 [PATCHSET] 0/15 IO scheduler improvements Al Boldi 2006-07-14 7:15 ` Jens Axboe 2006-07-14 19:53 ` Al Boldi 2006-07-15 11:06 ` Jens Axboe 2006-07-15 12:35 ` Al Boldi 2006-07-15 17:46 ` Jens Axboe 2006-07-15 20:27 ` Al Boldi 2006-07-16 11:26 ` Jens Axboe -- strict thread matches above, loose matches on Subject: below -- 2006-07-13 12:46 Jens Axboe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox