From: Greg KH <greg@kroah.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: stable@kernel.org, kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
rml@novell.com
Subject: Re: [stable] [patch-stable 2.6.16] pdflush: handle resume wakeups
Date: Mon, 17 Jul 2006 08:27:51 -0700 [thread overview]
Message-ID: <20060717152751.GD4888@kroah.com> (raw)
In-Reply-To: <20060708153731.GB1723@elf.ucw.cz>
On Sat, Jul 08, 2006 at 05:37:31PM +0200, Pavel Machek wrote:
>
> 2.6.16 needs this. It was merged into 2.6.18-rc1 in
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d616e09ab33aa4d013a93c9b393efd5cebf78521 .
>
> pdflush is carefully designed to ensure that all wakeups have some
> corresponding work to do - if a woken-up pdflush thread discovers that
> it hasn't been given any work to do then this is considered an error.
>
> That all broke when swsusp came along - because a timer-delivered
> wakeup to a frozen pdflush thread will just get lost. This causes the
> pdflush thread to get lost as well: the writeback timer is supposed to
> be re-armed by pdflush in process context, but pdflush doesn't execute
> the callout which does this.
>
> Fix that up by ignoring the return value from try_to_freeze(): jsut
> proceed, see if we have any work pending and only go back to sleep if
> that is not the case.
Queued to -stable, thanks.
greg k-h
prev parent reply other threads:[~2006-07-17 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-08 15:37 [patch-stable 2.6.16] pdflush: handle resume wakeups Pavel Machek
2006-07-17 15:27 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060717152751.GD4888@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rml@novell.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox