Re: [patch 27/45] tpm: interrupt clear fix

Kylene Jo Hall
2006-07-17T16:55:59Z

There was a different patch proposed and accepted already for this fix
based on comments on the list.

Thanks,
Kylie

On Mon, 2006-07-17 at 09:28 -0700, Greg KH wrote:
> plain text document attachment (tpm-interrupt-clear-fix.patch)
> -stable review patch. If anyone has any objections, please let us know.
>
> ------------------
> From: Kylene Jo Hall <kjhall@us.ibm.com>
>
> Under stress testing I found that the interrupt is not always cleared.
> This is a bug and this patch should go into 2.6.18 and 2.6.17.x.
>
> Signed-off-by: Kylene Hall <kjhall@us.ibm.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> ---
> drivers/char/tpm/tpm_tis.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-2.6.17.6.orig/drivers/char/tpm/tpm_tis.c
> +++ linux-2.6.17.6/drivers/char/tpm/tpm_tis.c
> @@ -424,6 +424,7 @@ static irqreturn_t tis_int_handler(int i
> iowrite32(interrupt,
> chip->vendor.iobase +
> TPM_INT_STATUS(chip->vendor.locality));
> + mb();
> return IRQ_HANDLED;
> }
>
>
> --