Re: [RFC: -mm patch] drivers/char/scx200_gpio.c: make code static

Adrian Bunk
2006-07-15T15:37:49Z

On Sat, Jul 15, 2006 at 03:49:07PM +0100, Chris Boot wrote:
> Adrian Bunk wrote:
> >This patch makes needlessly global code static.
>
> I don't agree with unexporting scx200_gpio_ops and making the struct
> static, this lets other modules use the scx200_gpio module in a
> semi-independent way. My net48xx LED Class code is going to be modified to
> use the entries in this struct to do its GPIO-twiddling magic, potentially
> allowing my module to do more than just the net48xx Error LED.
>...

Can you express "is going to be modified" in the unit "days"?

I've seen too many times that someone said "I will need this export
soon", and some months or even a year later the code using it was still
part of the kernel.

Unexporting something today does still allow re-exporting it when it's
actually required - simply add the trivial patch undoing my unexport
when you submit your driver for inclusion in the kernel.

> Chris Boot

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed