[patch] mdacon: fix __init section warnings

Frederik Deweerdt
2006-07-22T09:49:55Z

On Thu, Jul 13, 2006 at 10:48:00PM -0700, Andrew Morton wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc1/2.6.18-rc1-mm2/
>
> - Patches were merged, added, dropped and fixed. Nothing particularly exciting.
>
Compilation issues the following warnings:
WARNING: drivers/video/console/mdacon.o - Section mismatch: reference to .init.text: from .text between 'mdacon_startup' (at offset 0x123) and 'mdacon_init'
WARNING: drivers/video/console/mdacon.o - Section mismatch: reference to .init.text: from .text between 'mdacon_startup' (at offset 0x18b) and 'mdacon_init'

The attached patch removes the __init directives from mda_detect and mda_initialize which are
called from mdacon_startup (which is not __init tagged).

Regards,
Frederik

--- drivers/video/console/mdacon.c~mdacon-section-warning-fix.patch 2006-07-22 11:40:21.000000000 +0200
+++ drivers/video/console/mdacon.c 2006-07-22 11:34:20.000000000 +0200
@@ -197,7 +197,7 @@ static int __init mdacon_setup(char *str
__setup("mdacon=", mdacon_setup);
#endif

-static int __init mda_detect(void)
+static int mda_detect(void)
{
int count=0;
u16 *p, p_save;
@@ -282,7 +282,7 @@ static int __init mda_detect(void)
return 1;
}

-static void __init mda_initialize(void)
+static void mda_initialize(void)
{
write_mda_b(97, 0x00); /* horizontal total */
write_mda_b(80, 0x01); /* horizontal displayed */