Re: [RFC: -mm patch] drivers/char/scx200_gpio.c: make code static

Chris Boot
2006-07-15T17:10:10Z

Adrian Bunk wrote:
> On Sat, Jul 15, 2006 at 03:49:07PM +0100, Chris Boot wrote:
>> Adrian Bunk wrote:
>>> This patch makes needlessly global code static.
>> I don't agree with unexporting scx200_gpio_ops and making the struct
>> static, this lets other modules use the scx200_gpio module in a
>> semi-independent way. My net48xx LED Class code is going to be modified to
>> use the entries in this struct to do its GPIO-twiddling magic, potentially
>> allowing my module to do more than just the net48xx Error LED.
>> ...
>
> Can you express "is going to be modified" in the unit "days"?

Hopefully this weekend!

I also have a good mind to do some work on both the scx200_gpio and pc8736x_gpio
modules to allow whole banks of GPIOs to be changed at once, but that's slightly
unrelated.

> I've seen too many times that someone said "I will need this export
> soon", and some months or even a year later the code using it was still
> part of the kernel.
>
> Unexporting something today does still allow re-exporting it when it's
> actually required - simply add the trivial patch undoing my unexport
> when you submit your driver for inclusion in the kernel.

Indeed not but it seems silly to remove one line of code one day and revert it
the next, unnecessarily!

Chris

--
Chris Boot
bootc@bootc.net