Re: [RFC: -mm patch] drivers/char/scx200_gpio.c: make code static

Jim Cromie
2006-07-15T23:49:04Z

Adrian Bunk wrote:
> This patch makes needlessly global code static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
>
Nak on 1st 2 chunks - exported vtable is now used, an should (hopefully)
serve as a universal gpio interface.
Here it is again, with the 2 chunks stripped.

---

This patch makes a needlessly global variable static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---

$ diffstat fxd1/scx200_gpio.c-make-code-static.eml
scx200_gpio.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.18-rc1-mm2-full/drivers/char/scx200_gpio.c.old 2006-07-14 22:31:22.000000000 +0200
+++ linux-2.6.18-rc1-mm2-full/drivers/char/scx200_gpio.c 2006-07-14 22:31:44.000000000 +0200
@@ -69,7 +68,7 @@
.release = scx200_gpio_release,
};

-struct cdev scx200_gpio_cdev; /* use 1 cdev for all pins */
+static struct cdev scx200_gpio_cdev; /* use 1 cdev for all pins */

static int __init scx200_gpio_init(void)
{