Re: [linux-usb-devel] [RFC: -mm patch] drivers/usb/core/driver.c: make 2 functions static

Alan Stern
2006-07-15T12:50:04Z

On Sat, 15 Jul 2006, Adrian Bunk wrote:

> This patch makes two needlessly global functions static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
...
> --- linux-2.6.18-rc1-mm2-full/drivers/usb/core/driver.c.old 2006-07-14 23:29:20.000000000 +0200
> +++ linux-2.6.18-rc1-mm2-full/drivers/usb/core/driver.c 2006-07-14 23:29:51.000000000 +0200
> @@ -471,7 +471,7 @@
> }
> EXPORT_SYMBOL_GPL_FUTURE(usb_match_id);
>
> -int usb_device_match(struct device *dev, struct device_driver *drv)
> +static int usb_device_match(struct device *dev, struct device_driver *drv)
> {
> /* devices and interfaces are handled separately */
> if (is_usb_device(dev)) {
> @@ -877,7 +877,7 @@
> }
>
> /* Caller has locked udev */
> -int usb_suspend_both(struct usb_device *udev, pm_message_t msg)
> +static int usb_suspend_both(struct usb_device *udev, pm_message_t msg)
> {
> int status = 0;
> int i = 0;

There's no problem with making usb_device_match() static, but I've got a
patch almost ready for submission which needs usb_suspend_both() to be
publicly visible.

Alan Stern