public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: Martin Waitz <tali@admingilde.org>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][kernel-doc] Add DocBook documentation for workqueue functions
Date: Thu, 20 Jul 2006 15:03:54 +0200	[thread overview]
Message-ID: <200607201503.55036.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0607200548210.30200@shark.he.net>

Randy Dunlap wrote:
> On Thu, 20 Jul 2006, Rolf Eike Beer wrote:
> > kernel/workqueue.c was omitted from generating kernel documentation. This
> > adds a new section "Workqueues and Kevents" and adds documentation for
> > some of the functions.
> >
> > Some functions in this file already had DocBook-style comments, now they
> > finally become visible
>
> Cool, thanks much.
>
> Did you test it?

At least two of them.

> There should not be an empty ("*" only) line 
> between the function name + short description and the function
> parameter line(s).  If you generate output for these functions,
> the Description section will be there 2 times (i.e., repeated),
> so please just delete those lines and it will be Good.

Yes, I saw that. That's a very common problem all over the kernel. Now I see 
that the nano-howto says it's this way, but I've seen the other way for 
years. One example is vmalloc_32_user that I touched on monday.

I'll submit a version 3 of this soon. In the meantime "make mandocs" should 
either warn of those or handle them the right way (aka ignore the newline). 
If it would also warn on duplicate descriptions, at least in the same file, 
this would have catched my copy&waste bug in the first version also.

Eike

  reply	other threads:[~2006-07-20 13:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-20  9:45 [PATCH][kernel-doc] Add DocBook documentation for workqueue functions Rolf Eike Beer
2006-07-20 11:49 ` Stefan Richter
2006-07-20 12:22   ` Rolf Eike Beer
2006-07-20 12:52 ` Randy.Dunlap
2006-07-20 13:03   ` Rolf Eike Beer [this message]
2006-07-20 13:11 ` Rolf Eike Beer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200607201503.55036.eike-kernel@sf-tec.de \
    --to=eike-kernel@sf-tec.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=tali@admingilde.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox