From: Michael Halcrow <mhalcrow@us.ibm.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Sane return value for ecryptfs_commit_write()
Date: Thu, 20 Jul 2006 14:34:19 -0500 [thread overview]
Message-ID: <20060720193419.GA12086@us.ibm.com> (raw)
Calling functions expect the return value from ecryptfs_commit_write()
to be 0 on success.
Signed-off-by: Michael Halcrow <mhalcrow@us.ibm.com>
---
fs/ecryptfs/mmap.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
9c56c9f6f49840860068b461c1d956391cbc5550
diff --git a/fs/ecryptfs/mmap.c b/fs/ecryptfs/mmap.c
index 65e7331..8a4040d 100644
--- a/fs/ecryptfs/mmap.c
+++ b/fs/ecryptfs/mmap.c
@@ -628,7 +628,6 @@ static int ecryptfs_commit_write(struct
{
struct ecryptfs_page_crypt_context ctx;
loff_t pos;
- unsigned bytes = to - from;
struct inode *inode;
struct inode *lower_inode;
struct file *lower_file;
@@ -671,7 +670,7 @@ static int ecryptfs_commit_write(struct
"index [0x%.16x])\n", page->index);
goto out;
}
- rc = bytes;
+ rc = 0;
inode->i_blocks = lower_inode->i_blocks;
pos = (page->index << PAGE_CACHE_SHIFT) + to;
if (pos > i_size_read(inode)) {
--
1.3.3
reply other threads:[~2006-07-24 19:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060720193419.GA12086@us.ibm.com \
--to=mhalcrow@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox