From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Paul Jackson <pj@sgi.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
Simon.Derr@bull.net, linux-kernel@vger.kernel.org,
Dimitri Sivanich <sivanich@sgi.com>
Subject: Re: [BUG] Cpuset: dynamic sched domain crash on > 16 cpu systems.
Date: Thu, 20 Jul 2006 23:09:09 -0700 [thread overview]
Message-ID: <20060720230909.A4984@unix-os.sc.intel.com> (raw)
In-Reply-To: <20060720132959.31161.284.sendpatchset@v0>; from pj@sgi.com on Thu, Jul 20, 2006 at 06:29:59AM -0700
Paul,
I don't have these type of systems. So can you please check if the appended
patch fixes your issue.
thanks,
suresh
--
Use the correct groups while initializing sched groups power for
allnodes_domain. This fixes the crash observed while creating
exclusive cpusets.
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
--- linux-2.6.18-rc1/kernel/sched.c~ 2006-07-20 20:54:44.425601384 -0700
+++ linux-2.6.18-rc1/kernel/sched.c 2006-07-20 21:05:05.535178376 -0700
@@ -6457,7 +6457,12 @@ static int build_sched_domains(const cpu
for (i = 0; i < MAX_NUMNODES; i++)
init_numa_sched_groups_power(sched_group_nodes[i]);
- init_numa_sched_groups_power(sched_group_allnodes);
+ if (sched_group_allnodes) {
+ int group = cpu_to_allnodes_group(first_cpu(*cpu_map));
+ struct sched_group *sg = &sched_group_allnodes[group];
+
+ init_numa_sched_groups_power(sg);
+ }
#endif
/* Attach the domains */
next prev parent reply other threads:[~2006-07-21 6:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-20 13:29 [BUG] Cpuset: dynamic sched domain crash on > 16 cpu systems Paul Jackson
2006-07-21 6:09 ` Siddha, Suresh B [this message]
2006-07-21 7:14 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060720230909.A4984@unix-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=Simon.Derr@bull.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=sivanich@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox