From: Andrew Morton <akpm@osdl.org>
To: Rodolfo Giometti <giometti@linux.it>
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] no console disabling during suspend stage
Date: Fri, 21 Jul 2006 06:05:13 -0700 [thread overview]
Message-ID: <20060721060513.fd78b793.akpm@osdl.org> (raw)
In-Reply-To: <20060719091559.GD25330@enneenne.com>
On Wed, 19 Jul 2006 11:16:00 +0200
Rodolfo Giometti <giometti@linux.it> wrote:
> here a little patch to avoid disabling console during suspend stage
> while we are debugging kernel.
>
> ...
>
> --- kernel/power/main.c 2006-07-19 10:54:11.000000000 +0200
> +++ kernel/power/main.c.new 2006-07-18 19:38:41.000000000 +0200
> @@ -86,7 +86,9 @@
> goto Thaw;
> }
>
> +#ifndef CONFIG_DEBUG_KERNEL
> suspend_console();
> +#endif
CONFIG_DEBUG_KERNEL is not really the appropriate thing to use here - it's
more a user-interface/Kconfig level thing.
Can you please describe the problems which suspend_console() are causing?
Some runtime knob might be more appropriate. Perhaps /sys/power/debug?
If the suspend_console() call is to be disabled then you'll want to disable
the matching resume_console() call too.
printk.c needs sem2mutex conversion.
The console_suspended/secondary_console_sem handling is racy. Bad Linus.
But as we're running on a single CPU and all other tasks are frozen it
doesn't matter.
prev parent reply other threads:[~2006-07-21 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-19 9:16 [PATCH] no console disabling during suspend stage Rodolfo Giometti
2006-07-21 13:05 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060721060513.fd78b793.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=giometti@linux.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox