From: Frederik Deweerdt <deweerdt@free.fr>
To: takis@issaris.org
Cc: linux-kernel@vger.kernel.org, rathamahata@php4.ru,
sfrench@samba.org, jffs-dev@axis.com, shaggy@austin.ibm.com,
neilb@cse.unsw.edu.au, trond.myklebust@fys.uio.no,
reiserfs-dev@namesys.com, raven@themaw.net
Subject: Re: [PATCH] fs: Memory allocation cleanups
Date: Fri, 21 Jul 2006 16:37:23 +0200 [thread overview]
Message-ID: <20060721143723.GB2772@slug> (raw)
In-Reply-To: <20060721115055.GA12329@issaris.org>
On Fri, Jul 21, 2006 at 01:50:55PM +0200, takis@issaris.org wrote:
> - dnotify_req = (struct dir_notify_req *) kmalloc(
> - sizeof(struct dir_notify_req),
> + dnotify_req = kmalloc(sizeof(struct dir_notify_req),
> GFP_KERNEL);
^^^^^
Should be aligned with the kmalloc?
> - ext_acl = (reiserfs_acl_header *) kmalloc(sizeof(reiserfs_acl_header) +
> - acl->a_count *
> + ext_acl = kmalloc(sizeof(reiserfs_acl_header) + acl->a_count *
> sizeof(reiserfs_acl_entry),
> GFP_NOFS);
^^^^^
This should be aligned too, I think.
Regards,
Frederik
next prev parent reply other threads:[~2006-07-21 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-21 11:50 [PATCH] fs: Memory allocation cleanups takis
2006-07-21 14:37 ` Frederik Deweerdt [this message]
2006-07-24 14:41 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060721143723.GB2772@slug \
--to=deweerdt@free.fr \
--cc=jffs-dev@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=rathamahata@php4.ru \
--cc=raven@themaw.net \
--cc=reiserfs-dev@namesys.com \
--cc=sfrench@samba.org \
--cc=shaggy@austin.ibm.com \
--cc=takis@issaris.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox