e1000: "fix" it on thinkpad x60

e1000: "fix" it on thinkpad x60

[Pavel Machek]

e1000 in thinkpad x60 fails without this dirty hack. What to do with
it?

Signed-off-by: Pavel Machek <pavel@suse.cz>

---
commit 6414eba4f65ded35f3a8f2d61261d1134e292506
tree e6560bba2cc0d18b76075e6b5db415d6c0c31db3
parent fa6f216422f9020c06dd1137aec8c72224cbe440
author <pavel@amd.ucw.cz> Fri, 21 Jul 2006 02:16:52 +0200
committer <pavel@amd.ucw.cz> Fri, 21 Jul 2006 02:16:52 +0200

 drivers/net/e1000/e1000_main.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 6e7d31b..808c442 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -842,8 +842,10 @@ e1000_probe(struct pci_dev *pdev,
 
 	if (e1000_validate_eeprom_checksum(&adapter->hw) < 0) {
 		DPRINTK(PROBE, ERR, "The EEPROM Checksum Is Not Valid\n");
+/*
 		err = -EIO;
 		goto err_eeprom;
+*/
 	}
 
 	/* copy the MAC address out of the EEPROM */

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: e1000: "fix" it on thinkpad x60 / eeprom checksum read fails

[Auke Kok]

Pavel Machek wrote:
> e1000 in thinkpad x60 fails without this dirty hack. What to do with
> it?
> 
> Signed-off-by: Pavel Machek <pavel@suse.cz>

NAK, certainly this should never be merged in any tree...



this is a known issue that we're tracking here:

http://sourceforge.net/tracker/index.php?func=detail&aid=1474679&group_id=42302&atid=447449

Summary of the issue:

Lenovo has used certain BIOS versions where ASPD/DSPD was turned on which 
turns the PHY off when no cable is inserted to save power. The e1000 driver 
already turns off this feature but can't do this until the driver is loaded. 
It seems that turning this feature on causes the MAC to give read errors.

Lenovo seems to have the feature turned off in their latest BIOS versions, we 
encourage all people to upgrade their BIOS with the latest version from Lenovo 
(available from their website). It seems that for at least 2 people, this has 
fixed the problem.

Inserting a cable obviously might also work :)

We did reproduce the problem initially with the old BIOS (1.01-1.03) on a T60 
system, but unfortunately the bug disappeared into nothingness.

Bypassing the checksum leaves the NIC in an uncertain state and is not 
recommended.

Auke

Re: e1000: "fix" it on thinkpad x60 / eeprom checksum read fails

[Pavel Machek]

Hi!

> >e1000 in thinkpad x60 fails without this dirty hack. What to do with
> >it?
> >
> >Signed-off-by: Pavel Machek <pavel@suse.cz>
> 
> NAK, certainly this should never be merged in any tree...
> 
> this is a known issue that we're tracking here:
> 
> http://sourceforge.net/tracker/index.php?func=detail&aid=1474679&group_id=42302&atid=447449
> 
> Summary of the issue:
> 
> Lenovo has used certain BIOS versions where ASPD/DSPD was turned on which 
> turns the PHY off when no cable is inserted to save power. The e1000 driver 
> already turns off this feature but can't do this until the driver is 
> loaded. It seems that turning this feature on causes the MAC to give read 
> errors.
> 
> Lenovo seems to have the feature turned off in their latest BIOS versions, 
> we encourage all people to upgrade their BIOS with the latest version from 
> Lenovo (available from their website). It seems that for at least 2 people, 
> this has fixed the problem.
> 
> Inserting a cable obviously might also work :)

Hehe.

> We did reproduce the problem initially with the old BIOS (1.01-1.03) on a 
> T60 system, but unfortunately the bug disappeared into nothingness.
> 
> Bypassing the checksum leaves the NIC in an uncertain state and is not 
> recommended.

Okay, perhaps this should be inserted as a comment into the driver,
and printk should be fixed to point at this explanation?

Can't we enable the driver with the bad checksum, then read the _real_
data?
								Pavel
-- 
Thanks, Sharp!

Re: e1000: "fix" it on thinkpad x60 / eeprom checksum read fails

[Auke Kok]

Pavel Machek wrote:
> Hi!
> 
>>> e1000 in thinkpad x60 fails without this dirty hack. What to do with
>>> it?
>>>
>>> Signed-off-by: Pavel Machek <pavel@suse.cz>
>> NAK, certainly this should never be merged in any tree...
>>
>> this is a known issue that we're tracking here:
>>
>> http://sourceforge.net/tracker/index.php?func=detail&aid=1474679&group_id=42302&atid=447449
>>
>> Summary of the issue:
>>
>> Lenovo has used certain BIOS versions where ASPD/DSPD was turned on which 
>> turns the PHY off when no cable is inserted to save power. The e1000 driver 
>> already turns off this feature but can't do this until the driver is 
>> loaded. It seems that turning this feature on causes the MAC to give read 
>> errors.
>>
>> Lenovo seems to have the feature turned off in their latest BIOS versions, 
>> we encourage all people to upgrade their BIOS with the latest version from 
>> Lenovo (available from their website). It seems that for at least 2 people, 
>> this has fixed the problem.
>>
>> Inserting a cable obviously might also work :)
> 
> Hehe.
> 
>> We did reproduce the problem initially with the old BIOS (1.01-1.03) on a 
>> T60 system, but unfortunately the bug disappeared into nothingness.
>>
>> Bypassing the checksum leaves the NIC in an uncertain state and is not 
>> recommended.
> 
> Okay, perhaps this should be inserted as a comment into the driver,
> and printk should be fixed to point at this explanation?
> 
> Can't we enable the driver with the bad checksum, then read the _real_
> data?

no.

We're working on a solution where we make sure that the PHY is physically 
turned on properly before we read the EEPROM, which would be the proper fix. 
It's completely not acceptable to run when the EEPROM checksum fails - you 
might even be running with the wrong MAC address, or worse. Lets fix this the 
right way instead.

Auke

PS: adding netdev to the CC...

Re: e1000: "fix" it on thinkpad x60 / eeprom checksum read fails

[Andrew Morton]

On Thu, 20 Jul 2006 10:34:23 -0700
Auke Kok <auke-jan.h.kok@intel.com> wrote:

> > Okay, perhaps this should be inserted as a comment into the driver,
> > and printk should be fixed to point at this explanation?
> > 
> > Can't we enable the driver with the bad checksum, then read the _real_
> > data?
> 
> no.
> 
> We're working on a solution where we make sure that the PHY is physically 
> turned on properly before we read the EEPROM, which would be the proper fix. 
> It's completely not acceptable to run when the EEPROM checksum fails - you 
> might even be running with the wrong MAC address, or worse. Lets fix this the 
> right way instead.

A printk which helps the user to understand all this saga would be very nice.

Re: e1000: "fix" it on thinkpad x60 / eeprom checksum read fails

[Theodore Tso]

On Fri, Jul 21, 2006 at 06:41:05AM -0700, Andrew Morton wrote:
> > It's completely not acceptable to run when the EEPROM checksum fails - you 
> > might even be running with the wrong MAC address, or worse. Lets fix this the 
> > right way instead.
> 
> A printk which helps the user to understand all this saga would be very nice.
> -

And if someone who understands all of these details could put a note
in the thinkwiki (say, here:
http://www.thinkwiki.org/wiki/Ethernet_Controllers#Intel_Gigabit_.2810.2F100.2F1000.29)
it would be greatly appreciated.

						- Ted

Re: e1000: "fix" it on thinkpad x60 / eeprom checksum read fails

[Auke Kok]

Theodore Tso wrote:
> On Fri, Jul 21, 2006 at 06:41:05AM -0700, Andrew Morton wrote:
>>> It's completely not acceptable to run when the EEPROM checksum fails - you 
>>> might even be running with the wrong MAC address, or worse. Lets fix this the 
>>> right way instead.
>> A printk which helps the user to understand all this saga would be very nice.
>> -
> 
> And if someone who understands all of these details could put a note
> in the thinkwiki (say, here:
> http://www.thinkwiki.org/wiki/Ethernet_Controllers#Intel_Gigabit_.2810.2F100.2F1000.29)
> it would be greatly appreciated.
> 

why don't I do that :)


Andrew: I'm contemplating that printk...


Cheers,

Auke

Re: e1000: "fix" it on thinkpad x60 / eeprom checksum read fails

[Andrew Morton]

On Fri, 21 Jul 2006 08:22:38 -0700
Auke Kok <auke-jan.h.kok@intel.com> wrote:

> > And if someone who understands all of these details could put a note
> > in the thinkwiki (say, here:
> > http://www.thinkwiki.org/wiki/Ethernet_Controllers#Intel_Gigabit_.2810.2F100.2F1000.29)
> > it would be greatly appreciated.
> > 
> 
> why don't I do that :)
> 
> 
> Andrew: I'm contemplating that printk...

Print the wiki URL ;)