Re: How long to wait on patches?

Re: How long to wait on patches?

[David Lang]

On Fri, 21 Jul 2006, Matt LaPlante wrote:

> I checked the FAQ but didn't see an answer to this.  Over the past few weeks 
> I've submitted probably around 8 simple typo-fix patches all of which seemed 
> to be approved by others on the list.  I've been following the GIT, but these 
> patches haven't been merged yet.  I know people are busy with other things, 
> probably more important, but I would like to know how long is "acceptable" to 
> wait before I should re-submit a patch.  Obviously if enough time passes, 
> patches start to break as source files change.  I don't mean to be a nuisance; 
> I'm just trying to determine proper protocol.  That and the fact I can submit 
> several more patches once I get some of these old ones out of my queue. :)

be sure to watch the -mm tree as well, a lot of patches are picked up by Andrew 
to be fed to Linus that way

this is a particularly bad week since almost all the core developers were up at 
OLS.

one thing you may want to look at doing (hosting permitting) is to setup a git 
tree to just hold your trivial patches so that they can be pulled easily.

I thought there was a person who was maintaining a -trivial tree for this 
purpose, I don't remember who it was though.

David Lang

How long to wait on patches?

[Matt LaPlante]

I checked the FAQ but didn't see an answer to this.  Over the past few weeks I've submitted probably around 8 simple typo-fix patches all of which seemed to be approved by others on the list.  I've been following the GIT, but these patches haven't been merged yet.  I know people are busy with other things, probably more important, but I would like to know how long is "acceptable" to wait before I should re-submit a patch.  Obviously if enough time passes, patches start to break as source files change.  I don't mean to be a nuisance; I'm just trying to determine proper protocol.  That and the fact I can submit several more patches once I get some of these old ones out of my queue. :)

--
Matt LaPlante
kernel1@cyberdogtech.com

Re: How long to wait on patches?

[Randy Dunlap]

> On Fri, 21 Jul 2006, Matt LaPlante wrote:
> 
> > I checked the FAQ but didn't see an answer to this.  Over the past
few weeks 
> > I've submitted probably around 8 simple typo-fix patches all of
which seemed 
> > to be approved by others on the list.  I've been following the GIT,
but these 
> > patches haven't been merged yet.  I know people are busy with other
things, 
> > probably more important, but I would like to know how long is
"acceptable" to 
> > wait before I should re-submit a patch.  Obviously if enough time
passes, 
> > patches start to break as source files change.  I don't mean to be a
nuisance; 
> > I'm just trying to determine proper protocol.  That and the fact I
can submit 
> > several more patches once I get some of these old ones out of my
queue. :)
> 
> be sure to watch the -mm tree as well, a lot of patches are picked up
by Andrew 
> to be fed to Linus that way
> 
> this is a particularly bad week since almost all the core developers
were up at 
> OLS.
> 
> one thing you may want to look at doing (hosting permitting) is to
setup a git 
> tree to just hold your trivial patches so that they can be pulled easily.
> 
> I thought there was a person who was maintaining a -trivial tree for this 
> purpose, I don't remember who it was though.


Yes, Adrian Bunk accepts and forwards trivial patches. See
http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/

---
~Randy

RE: How long to wait on patches?

[Matt LaPlante]

> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@xenotime.net]
> Sent: Friday, July 21, 2006 9:07 PM
> To: David Lang; Matt LaPlante; linux-kernel@vger.kernel.org
> Subject: Re: How long to wait on patches?
> 
> 
> 
> > On Fri, 21 Jul 2006, Matt LaPlante wrote:
> >
> >[me]
> >
> > be sure to watch the -mm tree as well, a lot of patches are picked up
> by Andrew
> > to be fed to Linus that way
> >
> > this is a particularly bad week since almost all the core developers
> were up at
> > OLS.
> >
> > one thing you may want to look at doing (hosting permitting) is to
> setup a git
> > tree to just hold your trivial patches so that they can be pulled
> easily.
> >
> > I thought there was a person who was maintaining a -trivial tree for
> this
> > purpose, I don't remember who it was though.
> 
> 
> Yes, Adrian Bunk accepts and forwards trivial patches. See
> http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/
> 
> ---
> ~Randy

Yes, my patches were CC'd to the trivial alias.  I guess from what I've read
on that page that I should wait until after .18 to look for them in the git?

-
Matt 

RE: How long to wait on patches?

[Randy Dunlap]

> > -----Original Message-----
> > From: Randy Dunlap [mailto:rdunlap@xenotime.net]
> > Sent: Friday, July 21, 2006 9:07 PM
> > To: David Lang; Matt LaPlante; linux-kernel@vger.kernel.org
> > Subject: Re: How long to wait on patches?
> > 
> > 
> > 
> > > On Fri, 21 Jul 2006, Matt LaPlante wrote:
> > >
> > >[me]
> > >
> > > be sure to watch the -mm tree as well, a lot of patches are picked up
> > by Andrew
> > > to be fed to Linus that way
> > >
> > > this is a particularly bad week since almost all the core developers
> > were up at
> > > OLS.
> > >
> > > one thing you may want to look at doing (hosting permitting) is to
> > setup a git
> > > tree to just hold your trivial patches so that they can be pulled
> > easily.
> > >
> > > I thought there was a person who was maintaining a -trivial tree for
> > this
> > > purpose, I don't remember who it was though.
> > 
> > 
> > Yes, Adrian Bunk accepts and forwards trivial patches. See
> > http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/
> > 
> > ---
> > ~Randy
> 
> Yes, my patches were CC'd to the trivial alias.  I guess from what
I've read
> on that page that I should wait until after .18 to look for them in
the git?

You mean in Linus's git tree?  Adrian will have to answer that
question, although the answer is likely to be Yes.  Linus recently
said that he accepts patches until -rc2 and after that he is
looking for stability and bug fixes for a final release, so
it could well be after 2.6.18 when they are merged.

---
~Randy

RE: How long to wait on patches?

[Matt LaPlante]

> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@xenotime.net]
> Sent: Friday, July 21, 2006 9:26 PM
> To: Matt LaPlante; 'Randy Dunlap'; 'David Lang'; linux-
> kernel@vger.kernel.org
> Subject: RE: How long to wait on patches?
> 
> 
> 
> > > -----Original Message-----
> > > From: Randy Dunlap [mailto:rdunlap@xenotime.net]
> > > Sent: Friday, July 21, 2006 9:07 PM
> > > To: David Lang; Matt LaPlante; linux-kernel@vger.kernel.org
> > > Subject: Re: How long to wait on patches?
> > >
> > >
> > >
> > > > On Fri, 21 Jul 2006, Matt LaPlante wrote:
> > > >
> > > >[me]
> > > >
> > > > be sure to watch the -mm tree as well, a lot of patches are picked
> up
> > > by Andrew
> > > > to be fed to Linus that way
> > > >
> > > > this is a particularly bad week since almost all the core developers
> > > were up at
> > > > OLS.
> > > >
> > > > one thing you may want to look at doing (hosting permitting) is to
> > > setup a git
> > > > tree to just hold your trivial patches so that they can be pulled
> > > easily.
> > > >
> > > > I thought there was a person who was maintaining a -trivial tree for
> > > this
> > > > purpose, I don't remember who it was though.
> > >
> > >
> > > Yes, Adrian Bunk accepts and forwards trivial patches. See
> > > http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/
> > >
> > > ---
> > > ~Randy
> >
> > Yes, my patches were CC'd to the trivial alias.  I guess from what
> I've read
> > on that page that I should wait until after .18 to look for them in
> the git?
> 
> You mean in Linus's git tree?  Adrian will have to answer that
> question, although the answer is likely to be Yes.  Linus recently
> said that he accepts patches until -rc2 and after that he is
> looking for stability and bug fixes for a final release, so
> it could well be after 2.6.18 when they are merged.
> 
> ---
> ~Randy

Adrian has a trivial git tree which has been silent for a couple weeks too.
This is part of the reason I was curious if the patches were still sitting
in his inbox or if they'd been passed over.  Of course, that's a question
only he could answer.

-
Matt

Re: How long to wait on patches?

[Andrew Morton]

On Fri, 21 Jul 2006 15:45:08 -0700 (PDT)
David Lang <dlang@digitalinsight.com> wrote:

> > I checked the FAQ but didn't see an answer to this.  Over the past few weeks 
> > I've submitted probably around 8 simple typo-fix patches all of which seemed 
> > to be approved by others on the list.  I've been following the GIT, but these 
> > patches haven't been merged yet.  I know people are busy with other things, 
> > probably more important, but I would like to know how long is "acceptable" to 
> > wait before I should re-submit a patch.  Obviously if enough time passes, 
> > patches start to break as source files change.  I don't mean to be a nuisance; 
> > I'm just trying to determine proper protocol.  That and the fact I can submit 
> > several more patches once I get some of these old ones out of my queue. :)
> 
> be sure to watch the -mm tree as well, a lot of patches are picked up by Andrew 
> to be fed to Linus that way

Yes, I hoover up unloved patches from the mailing list.  But only from this
mailing list, and there are probably lots of potentially-useful patches on
other lists which get lost.

However I have a personal i-dont-do-typo-patches policy.  Resending them to
kernel-janitor-discuss@lists.sourceforge.net would be a good idea.

Re: How long to wait on patches?

[Randy Dunlap]

> On Fri, 21 Jul 2006 15:45:08 -0700 (PDT)
> David Lang <dlang@digitalinsight.com> wrote:
> 
> > > I checked the FAQ but didn't see an answer to this.  Over the past
few weeks 
> > > I've submitted probably around 8 simple typo-fix patches all of
which seemed 
> > > to be approved by others on the list.  I've been following the
GIT, but these 
> > > patches haven't been merged yet.  I know people are busy with
other things, 
> > > probably more important, but I would like to know how long is
"acceptable" to 
> > > wait before I should re-submit a patch.  Obviously if enough time
passes, 
> > > patches start to break as source files change.  I don't mean to be
a nuisance; 
> > > I'm just trying to determine proper protocol.  That and the fact I
can submit 
> > > several more patches once I get some of these old ones out of my
queue. :)
> > 
> > be sure to watch the -mm tree as well, a lot of patches are picked
up by Andrew 
> > to be fed to Linus that way
> 
> Yes, I hoover up unloved patches from the mailing list.  But only from
this
> mailing list, and there are probably lots of potentially-useful patches on
> other lists which get lost.
> 
> However I have a personal i-dont-do-typo-patches policy.  Resending
them to
> kernel-janitor-discuss@lists.sourceforge.net would be a good idea.

Please make that kernel-janitors@lists.osdl.org
The sf.net list/hosting is no longer used.

or just to trivial will also work.  Neither of them is especially
fast and should not be used for critical patches.

---
~Randy

Re: How long to wait on patches?

[Adrian Bunk]

On Fri, Jul 21, 2006 at 09:32:09PM -0400, Matt LaPlante wrote:
> 
> Adrian has a trivial git tree which has been silent for a couple weeks too.
> This is part of the reason I was curious if the patches were still sitting
> in his inbox or if they'd been passed over.  Of course, that's a question
> only he could answer.

I'm only forwarding trivial patches to Linus during the two weeks 
merging phase before -rc1.

Until then, they are sitting in my "trivial" mail folder.

> Matt

cu
Adrian

BTW: If you are expecting an answer from me, putting me in the Cc would 
     make me faster aware of your email.

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: How long to wait on patches?

[Matt LaPlante]

On Sat, 22 Jul 2006 18:09:24 +0200
Adrian Bunk <bunk@stusta.de> wrote:

> On Fri, Jul 21, 2006 at 09:32:09PM -0400, Matt LaPlante wrote:
> > 
> > Adrian has a trivial git tree which has been silent for a couple weeks too.
> > This is part of the reason I was curious if the patches were still sitting
> > in his inbox or if they'd been passed over.  Of course, that's a question
> > only he could answer.
> 
> I'm only forwarding trivial patches to Linus during the two weeks 
> merging phase before -rc1.
> 
> Until then, they are sitting in my "trivial" mail folder.
> 
> > Matt
> 
> cu
> Adrian
> 
> BTW: If you are expecting an answer from me, putting me in the Cc would 
>      make me faster aware of your email.
> 
> -- 
> 
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
> 

2.6.18 is out, so I feel the urge to revive a dead topic. :) Any idea when we might get my ancient trivials included in the new gits?  I'm still lurking around and ready to do more pointless doc-checking tasks, but I really want the old stuff merged so I can rebase around it.

Oh, and cheers to everyone on another great kernel release!

-- 
Matt

Re: How long to wait on patches?

[Adrian Bunk]

On Mon, Sep 25, 2006 at 10:52:12AM -0400, Matt LaPlante wrote:

> 2.6.18 is out, so I feel the urge to revive a dead topic. :) Any idea when we might get my ancient trivials included in the new gits?  I'm still lurking around and ready to do more pointless doc-checking tasks, but I really want the old stuff merged so I can rebase around it.
>...

During the 2 weeks until 2.6.19-rc1.

It wouldn't be good if I'd forward all the trivial patches today 
probably breaking the context for pending merges.

> Matt

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: How long to wait on patches?

[Matt LaPlante]

On Wed, 27 Sep 2006 01:45:05 +0200
Adrian Bunk <bunk@stusta.de> wrote:

> On Mon, Sep 25, 2006 at 10:52:12AM -0400, Matt LaPlante wrote:
> 
> > 2.6.18 is out, so I feel the urge to revive a dead topic. :) Any idea when we might get my ancient trivials included in the new gits?  I'm still lurking around and ready to do more pointless doc-checking tasks, but I really want the old stuff merged so I can rebase around it.
> >...
> 
> During the 2 weeks until 2.6.19-rc1.
> 
> It wouldn't be good if I'd forward all the trivial patches today 
> probably breaking the context for pending merges.

Alright, good to know.  If I may suggest:

99% of my changes are to text Docs, not source.  I don't believe we would be risking code breakage as a result of merging them.  In this case of course I don't expect you to root through the trivial box and pull out my patches, but maybe this isn't the best way for me to submit them in the first place?  It seems like a particularly small and unnecessary window for somebody to update text files in.  Is there a different tree or maintainer that would be better suited for this type of thing?

Thanks again.

-
Matt

> 
> cu
> Adrian
> 

Re: How long to wait on patches?

[Adrian Bunk]

On Wed, Sep 27, 2006 at 08:54:28PM -0400, Matt LaPlante wrote:
> On Wed, 27 Sep 2006 01:45:05 +0200
> Adrian Bunk <bunk@stusta.de> wrote:
> 
> > On Mon, Sep 25, 2006 at 10:52:12AM -0400, Matt LaPlante wrote:
> > 
> > > 2.6.18 is out, so I feel the urge to revive a dead topic. :) Any idea when we might get my ancient trivials included in the new gits?  I'm still lurking around and ready to do more pointless doc-checking tasks, but I really want the old stuff merged so I can rebase around it.
> > >...
> > 
> > During the 2 weeks until 2.6.19-rc1.
> > 
> > It wouldn't be good if I'd forward all the trivial patches today 
> > probably breaking the context for pending merges.
> 
> Alright, good to know.  If I may suggest:
> 
> 99% of my changes are to text Docs, not source.  I don't believe we would be risking code breakage as a result of merging them.  In this case of course I don't expect you to root through the trivial box and pull out my patches, but maybe this isn't the best way for me to submit them in the first place?  It seems like a particularly small and unnecessary window for somebody to update text files in.  Is there a different tree or maintainer that would be better suited for this type of thing?

I'm not talking about breaking code, I'm talking about breaking
_patch context_.

I have no problem with you sending your patches through subsystem 
maintainers or Andrew.

> Thanks again.
> Matt

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed