Re: [PATCH 3/3] scsi : megaraid_{mm,mbox}: a fix on "kernel unaligned access address" issue

[Rolf Eike Beer <eike-kernel@sf-tec.de>]

[-- Attachment #1: Type: text/plain, Size: 1672 bytes --]

Ju, Seokmann wrote:
> Hi,
>
> This is a third patch which follows prevous two patches ([PATCH 1/3] and
> [PATCH 2/3]).

Either use a [0/3] mail that describes the complete changeset or just send 
each patch as a reply to the previous one. This way they are grouped together 
in the mail programs. That keeps the inbox clean and the relationsship is 
clearer.

> Signed-Off By: Seokmann Ju <seokmann.ju@lsil.com>
> ---
> diff -Naur inqwithevpd/Documentation/scsi/ChangeLog.megaraid
> unaligned/Documentation/scsi/ChangeLog.megaraid
> --- inqwithevpd/Documentation/scsi/ChangeLog.megaraid	2006-07-24
> 15:35:02.000000000 -0400
> +++ unaligned/Documentation/scsi/ChangeLog.megaraid	2006-07-24
> 15:41:49.000000000 -0400
> @@ -66,6 +66,61 @@
>  	Fix: MegaRAID F/W has fixed the problem and being process of
> release,
>  	soon. Meanwhile, driver will filter out the request.
>
> +3.	One of member in the data structure of the driver leads unaligne
                                                                ^^^^^^^^
> +	issue on 64-bit platform.
> +	Customer reporeted "kernel unaligned access addrss" issue when
                                                   ^^^^^^

Typos.

> +	> -----Original Message-----
[...]

This is IMHO too much data for an in-kernel changelog. I would vote for 
including this in your commit comments, then it will be available as git 
comment and not inflate the kernel tree itself with text that's useless for 
most users. This is really only of interest if someone tries to find out 
something about the changes in this driver and then he's normally also 
interested in the diffs itself.

Eike

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]