From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S932349AbWGYTwv@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932349AbWGYTwv (ORCPT <rfc822;willy@w.ods.org>);
	Tue, 25 Jul 2006 15:52:51 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932486AbWGYTwv
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 25 Jul 2006 15:52:51 -0400
Received: from ogre.sisk.pl ([217.79.144.158]:28108 "EHLO ogre.sisk.pl")
	by vger.kernel.org with ESMTP id S932349AbWGYTwv (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 25 Jul 2006 15:52:51 -0400
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Adam Belay <abelay@novell.com>
Subject: Re: [patch] [resend] Fix swsusp with PNP BIOS
Date: Tue, 25 Jul 2006 21:52:09 +0200
User-Agent: KMail/1.9.3
Cc: Nigel Cunningham <ncunningham@linuxmail.org>,
       Ondrej Zary <linux@rainbow-software.org>,
       Linux List <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>
References: <200607242028.01666.linux@rainbow-software.org> <200607250923.18678.ncunningham@linuxmail.org> <1153855056.6508.24.camel@localhost.localdomain>
In-Reply-To: <1153855056.6508.24.camel@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200607252152.09421.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 25 July 2006 21:17, Adam Belay wrote:
> On Tue, 2006-07-25 at 09:23 +1000, Nigel Cunningham wrote:
> > Hi.
> > 
> > On Tuesday 25 July 2006 07:25, Rafael J. Wysocki wrote:
> > > Hi,
> > >
> > > On Monday 24 July 2006 20:28, Ondrej Zary wrote:
> > > > Hello,
> > > > swsusp is unable to suspend my machine (DTK FortisPro TOP-5A notebook)
> > > > with kernel 2.6.17.5 because it's unable to suspend PNP device 00:16
> > > > (mouse).
> > > >
> > > > The problem is in PNP BIOS. pnp_bus_suspend() calls pnp_stop_dev() for
> > > > the device if the device can be disabled according to pnp_can_disable().
> > > > The problem is that pnpbios_disable_resources() returns -EPERM if the
> > > > device is not dynamic (!pnpbios_is_dynamic()) but insert_device() happily
> > > > sets PNP_DISABLE capability/flag even if the device is not dynamic. So we
> > > > try to disable non-dynamic devices which will fail.
> > > > This patch prevents insert_device() from setting PNP_DISABLE if the
> > > > device is not dynamic and fixes suspend on my system.
> > >
> > > Thanks for the patch.
> > >
> > > Pavel, what do you think?
> > 
> > Adam is probably a better person to ask. (Added to cc).
> 
> I appreciate it.
> 
> > 
> > Regards,
> > 
> > Nigel
> 
> The patch looks good.

I'll send it to Andrew then.  I assume I can place your ACK on it?

Rafael