From: Greg KH <gregkh@suse.de>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: James Courtier-Dutton <James@superbug.co.uk>,
linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [RFC PATCH] Multi-threaded device probing
Date: Wed, 26 Jul 2006 00:27:12 -0700 [thread overview]
Message-ID: <20060726072712.GC6249@suse.de> (raw)
In-Reply-To: <44C6B269.4080607@s5r6.in-berlin.de>
On Wed, Jul 26, 2006 at 02:08:09AM +0200, Stefan Richter wrote:
> James Courtier-Dutton wrote:
> >What happens about the logging?
> >Surely one would want the output from one probe to be output into the
> >log as a block, and not mix the output from multiple simultaneous probes.
>
> Use single-line printks were possible, or mutex-protected multiline
> blocks where you really can't do without multiple lines of printks that
> really cannot be separated. (Don't perform time consuming functions
> within those mutexes; that would defeat the multithreaded probing...)
>
> To adjust printks is only the beginning of what is to be done to adapt
> single-threaded bus probes to multithreaded ones. There may be hidden
> assumptions that rely on single-threaded execution.
Yeah, some drivers really don't like it, the ata_piix driver for example
had to be changed to keep it from thinking it was really being hotpluged
instead of the initial probe sequence. Odds are there are lots of other
driver specific issues like this everywhere. That's why it's a driver
specific flag, when the authors of the driver say it's ready, then it
will be enabled for that driver.
thanks,
greg k-h
next prev parent reply other threads:[~2006-07-26 7:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-25 20:30 [RFC PATCH] Multi-threaded device probing Greg KH
2006-07-25 21:09 ` Alexey Dobriyan
2006-07-25 21:27 ` Greg KH
2006-07-25 21:27 ` H. Peter Anvin
2006-07-25 22:00 ` Dmitry Torokhov
2006-07-26 7:28 ` Greg KH
2006-07-25 22:15 ` James Courtier-Dutton
2006-07-26 0:08 ` Stefan Richter
2006-07-26 7:27 ` Greg KH [this message]
2006-07-26 7:24 ` Greg KH
2006-07-25 22:57 ` Keshavamurthy Anil S
2006-07-26 7:22 ` Greg KH
2006-07-26 0:34 ` Stefan Richter
2006-07-26 7:31 ` Greg KH
2006-07-26 11:29 ` Matthew Wilcox
2006-07-26 16:16 ` Greg KH
2006-07-26 16:42 ` Matthew Wilcox
2006-07-26 16:46 ` Greg KH
2006-07-27 0:02 ` Arnd Bergmann
2006-07-27 0:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060726072712.GC6249@suse.de \
--to=gregkh@suse.de \
--cc=James@superbug.co.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox