Re: [RFC PATCH] Multi-threaded device probing

Greg KH
2006-07-27T00:22:00Z

On Thu, Jul 27, 2006 at 02:02:00AM +0200, Arnd Bergmann wrote:
> On Tuesday 25 July 2006 22:30, Greg KH wrote:
> > --- gregkh-2.6.orig/include/linux/device.h
> > +++ gregkh-2.6/include/linux/device.h
> > @@ -105,6 +105,8 @@ struct device_driver {
> > ????????void????(*shutdown)?????(struct device * dev);
> > ????????int?????(*suspend)??????(struct device * dev, pm_message_t state);
> > ????????int?????(*resume)???????(struct device * dev);
> > +
> > +???????unsigned int multithread_probe:1;
> > ?};
> > ?
>
> Why use a bit field here? It ends up consuming sizeof(long) anyway
> and causes more complex code, with no obvious benefit.

Because we don't yet have a boolean type :)

Honestly, I don't really care, I can make it a char if people really
care (but due to padding, it would take up the same size as unsigned
long anyway...)

thanks,

greg k-h