Re: [RFC PATCH] Multi-threaded device probing

Greg KH
2006-07-25T21:31:47Z

On Wed, Jul 26, 2006 at 01:09:53AM +0400, Alexey Dobriyan wrote:
> On Tue, Jul 25, 2006 at 01:30:28PM -0700, Greg KH wrote:
> > This adds the infrastructure for drivers to do a threaded probe.
>
> > - goto ProbeFailed;
> > + goto probe_failed;
> > }
> > } else if (drv->probe) {
> > ret = drv->probe(dev);
> > if (ret) {
> > dev->driver = NULL;
> > - goto ProbeFailed;
> > + goto probe_failed;
> > }
> > }
> > device_bind_driver(dev);
> > ret = 1;
> > pr_debug("%s: Bound Device %s to Driver %s\n",
> > drv->bus->name, dev->bus_id, drv->name);
> > - goto Done;
> > + goto done;
> >
> > - ProbeFailed:
> > +probe_failed:
> > if (ret == -ENODEV || ret == -ENXIO) {
> > /* Driver matched, but didn't support device
> > * or device not found.
> > @@ -110,7 +99,53 @@ int driver_probe_device(struct device_dr
> > "%s: probe of %s failed with error %d\n",
> > drv->name, dev->bus_id, ret);
> > }
> > - Done:
> > +done:
>
> Removing these changes will make this patch smaller and do one thing. ;-)

Heh, yeah, it would, but cleaning up coding style violations at the same
time that I move code around is usually safe :)

thanks,

greg k-h