Re: [PATCH] TIF_NOTSC and SECCOMP prctl

[andrea@cpushare.com]

On Wed, Jul 26, 2006 at 10:07:39AM +0200, Ingo Molnar wrote:
> 
> * andrea@cpushare.com <andrea@cpushare.com> wrote:
> 
> > Here a repost of the last seccomp patch against current mainline 
> > including the preempt fix. This changes the seccomp API from 
> > /proc/<pid>/seccomp to a prctl (this will produce a smaller kernel) 
> > and it adds a TIF_NOTSC that seccomp sets. Only the current task can 
> > call disable_TSC (obviously because it hasn't a task_t param). This 
> > includes Chuck's patch to give zero runtime cost to the notsc feature.
> 
> please send a patch-queue that is properly split-up: the bugfix, the API 
> change and the TIF_NOTSC improvement.

Which bugfix do you mean? If you mean the preempt fix for the NOTSC
improvement it makes no sense to split it up from the NOTSC
part. There are no other bugfixes (the reduction of the notsc window
isn't strictly a bugfix, since the feature already helped).

I can split the API change from the NOTSC feature, I'll wait some more
days in the hope this one goes in. If it doesn't go in I'll follow
your suggestion and I'll try again later with the split up in the hope
to increase my chances.

>From my point of view it's not urgent to merge it, it's just the
anti-seccomp advocates that should want this patch being merged
urgently.