From: Sukadev Bhattiprolu <sukadev@us.ibm.com>
To: ranty@debian.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Cc: clg@fr.ibm.com, serue@us.ibm.com, haveblue@us.ibm.com,
sukadev@us.ibm.com
Subject: [PATCH] kthread: drivers/base/firmware_class.c
Date: Wed, 26 Jul 2006 16:59:02 -0700 [thread overview]
Message-ID: <20060726235902.GB9645@us.ibm.com> (raw)
This patch replaces kernel_thread() call in drivers/base/firmware_class.c
with kthread_create() since kernel_thread() is deprecated in drivers.
Signed-off-by: Sukadev Bhattiprolu (sukadev@us.ibm.com)
CC: Cedric Le Goater <clg@fr.ibm.com>
CC: Serge E. Hallyn <serue@us.ibm.com>
CC: Dave Hansen <haveblue@us.ibm.com>
CC: Manuel Estrada Sainz <ranty@debian.org>
drivers/base/firmware_class.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
Index: linux-2.6.18-rc2/drivers/base/firmware_class.c
===================================================================
--- linux-2.6.18-rc2.orig/drivers/base/firmware_class.c 2006-07-20 17:41:56.000000000 -0700
+++ linux-2.6.18-rc2/drivers/base/firmware_class.c 2006-07-20 17:44:43.000000000 -0700
@@ -16,6 +16,7 @@
#include <linux/interrupt.h>
#include <linux/bitops.h>
#include <linux/mutex.h>
+#include <linux/kthread.h>
#include <linux/firmware.h>
#include "base.h"
@@ -511,7 +512,6 @@ request_firmware_work_func(void *arg)
WARN_ON(1);
return 0;
}
- daemonize("%s/%s", "firmware", fw_work->name);
ret = _request_firmware(&fw, fw_work->name, fw_work->device,
fw_work->uevent);
if (ret < 0)
@@ -546,9 +546,9 @@ request_firmware_nowait(
const char *name, struct device *device, void *context,
void (*cont)(const struct firmware *fw, void *context))
{
+ struct task_struct *task;
struct firmware_work *fw_work = kmalloc(sizeof (struct firmware_work),
GFP_ATOMIC);
- int ret;
if (!fw_work)
return -ENOMEM;
@@ -566,14 +566,14 @@ request_firmware_nowait(
.uevent = uevent,
};
- ret = kernel_thread(request_firmware_work_func, fw_work,
- CLONE_FS | CLONE_FILES);
+ task = kthread_run(request_firmware_work_func, fw_work,
+ "firmware/%s", name);
- if (ret < 0) {
+ if (IS_ERR(task)) {
fw_work->cont(NULL, fw_work->context);
module_put(fw_work->module);
kfree(fw_work);
- return ret;
+ return PTR_ERR(task);
}
return 0;
}
next reply other threads:[~2006-07-26 23:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-26 23:59 Sukadev Bhattiprolu [this message]
2006-07-27 17:12 ` [PATCH] kthread: drivers/base/firmware_class.c Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060726235902.GB9645@us.ibm.com \
--to=sukadev@us.ibm.com \
--cc=akpm@osdl.org \
--cc=clg@fr.ibm.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ranty@debian.org \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox