From: Greg KH <gregkh@suse.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [RFC PATCH] Multi-threaded device probing
Date: Wed, 26 Jul 2006 17:20:09 -0700 [thread overview]
Message-ID: <20060727002009.GA9390@suse.de> (raw)
In-Reply-To: <200607270202.00854.arnd@arndb.de>
On Thu, Jul 27, 2006 at 02:02:00AM +0200, Arnd Bergmann wrote:
> On Tuesday 25 July 2006 22:30, Greg KH wrote:
> > --- gregkh-2.6.orig/include/linux/device.h
> > +++ gregkh-2.6/include/linux/device.h
> > @@ -105,6 +105,8 @@ struct device_driver {
> > ????????void????(*shutdown)?????(struct device * dev);
> > ????????int?????(*suspend)??????(struct device * dev, pm_message_t state);
> > ????????int?????(*resume)???????(struct device * dev);
> > +
> > +???????unsigned int multithread_probe:1;
> > ?};
> > ?
>
> Why use a bit field here? It ends up consuming sizeof(long) anyway
> and causes more complex code, with no obvious benefit.
Because we don't yet have a boolean type :)
Honestly, I don't really care, I can make it a char if people really
care (but due to padding, it would take up the same size as unsigned
long anyway...)
thanks,
greg k-h
prev parent reply other threads:[~2006-07-27 0:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-25 20:30 [RFC PATCH] Multi-threaded device probing Greg KH
2006-07-25 21:09 ` Alexey Dobriyan
2006-07-25 21:27 ` Greg KH
2006-07-25 21:27 ` H. Peter Anvin
2006-07-25 22:00 ` Dmitry Torokhov
2006-07-26 7:28 ` Greg KH
2006-07-25 22:15 ` James Courtier-Dutton
2006-07-26 0:08 ` Stefan Richter
2006-07-26 7:27 ` Greg KH
2006-07-26 7:24 ` Greg KH
2006-07-25 22:57 ` Keshavamurthy Anil S
2006-07-26 7:22 ` Greg KH
2006-07-26 0:34 ` Stefan Richter
2006-07-26 7:31 ` Greg KH
2006-07-26 11:29 ` Matthew Wilcox
2006-07-26 16:16 ` Greg KH
2006-07-26 16:42 ` Matthew Wilcox
2006-07-26 16:46 ` Greg KH
2006-07-27 0:02 ` Arnd Bergmann
2006-07-27 0:20 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060727002009.GA9390@suse.de \
--to=gregkh@suse.de \
--cc=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox