From: Paul Jackson <pj@sgi.com>
To: Martin Peschke <mp3@de.ibm.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch 1/2] CPU hotplug compatible alloc_percpu
Date: Thu, 27 Jul 2006 09:18:43 -0700 [thread overview]
Message-ID: <20060727091843.c2192bbc.pj@sgi.com> (raw)
In-Reply-To: <1153761414.2986.136.camel@dyn-9-152-230-71.boeblingen.de.ibm.com>
Martin wrote:
> +static inline int percpu_populate_mask(void *__pdata, size_t size, gfp_t gfp,
> + int cpu)
> +{
It seems odd to me that this signature of percpu_populate_mask()
has its last argument 'int cpu' for the !CONFIG_SMP case, but
the SMP signatures have 'cpumask_t mask'.
Shouldn't this function signature be the same for all CONFIG's?
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2006-07-27 16:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-24 17:16 [Patch 1/2] CPU hotplug compatible alloc_percpu Martin Peschke
2006-07-26 6:02 ` Andrew Morton
2006-07-28 6:20 ` Martin Peschke
2006-07-27 16:18 ` Paul Jackson [this message]
2006-07-28 6:15 ` Martin Peschke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060727091843.c2192bbc.pj@sgi.com \
--to=pj@sgi.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mp3@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox