suspend2 merge history [was Re: the " 'official' point of view" expressed by kernelnewbies.org regarding reiser4 inclusion]

Pavel Machek
2006-07-27T21:42:38Z

Hi!

> > > > A much more important effect is that non-maintainers aren't familiar
> > > > with coding and patch submission guidelines. For example, in
> > > > suspend2, Nigel first tried with patches that were too monolithic,
> > > > and then his next series was too broken down such that it was too
> > > > hard to review (and "git bisect" wouldn't work).
> > >
> > > All his submissions since 2004 or so? It's a little easy to limit
> > > oneself to the last two ones.
> >
> > Nigel did not do any submissions in 2004 or so. Check your fact, that
> > stuff was marked 'RFC' and yes I did comment on it.
>
> 2004-09-16 submission:
>
> http://lkml.org/lkml/2004/9/16/76
...
> http://lkml.org/lkml/2004/9/16/90

Yes, Nigel submitted part of suspend2 here (I do not think he
submitted compression code on that day, for example), but then

http://lkml.org/lkml/2004/9/16/347

came:

#I should mention, I'm planning on producing a BK tree with these patches
#(and ones to fix issues raised), so you won't have to include a long
#list in -mm eventually! It will be on suspend2.bkbits.net (not there
#yet).

That sounds like "don't merge it yet, I'll prepare better version" to
me.

> 2004-11-24 submission:
>
> http://lkml.org/lkml/2004/11/24/93
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Okay, this one is important. It starts with

#Hi everyone.
#
#I know that I still have work to do on suspend2, but thought it was high
#time I got around to properly submitting the code for review, so here goes.

That looks like request for review, not request for merge. Plus it was
to: lkml, while it should be to: maintainer (or maybe to: akpm). Well,
it also says "Suspend 2 merge" in subject..

> > He did 1 (one) submission that looked like SubmittingPatches at the
> > first sight, and that was very recent.
> >
> > Stop spreading lies.
>
> I am awaiting your apologies.

Okay, 11/24 looked closer to submission than I recalled. So I guess I
have to say "sorry".

So we have 1 submission for review in 11/2004 and 1 submission for -mm
merge in 2006, right?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html