From: Jason Lunz <lunz@falooley.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>,
Vojtech Pavlik <vojtech@suse.cz>
Subject: Re: [PATCH] amd74xx: implement suspend-to-ram
Date: Fri, 28 Jul 2006 13:13:57 -0400 [thread overview]
Message-ID: <20060728171357.GB17549@knob.reflex> (raw)
In-Reply-To: <1154105517.13509.153.camel@localhost.localdomain>
On Fri, Jul 28, 2006 at 05:51:55PM +0100, Alan Cox wrote:
> This beings in the IDE power step code. You should do that as a step
> before the win_idleimmediate I suspect. Theory is right, diagnosis is
> right, implementation is in the wrong place.
>
> You'll make a lot more people happy by fixing it in ide-io
OK, I'll see about moving it there. Will this still be
controller-specific, or are you suggesting this is something ide ought
to do globally?
I poked around in ide-io.c a little while writing the patch, but my
assumption so far has been that the core ide suspend is OK wrt s2ram,
since I never hear IDE cited as the reason for s2ram failure. Usually
it's ACPI or video problems.
I'm beginning to suspect that the real problem is that everyone who
experiences ide-related hangs when attempting s2ram switches to s2disk,
which sidesteps ide problems since the ide controller stays alive
throughout the process and gets reinitialized on resume. So I guess
ide/s2ram problems could be more common than is widely known.
Jason
next prev parent reply other threads:[~2006-07-28 17:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-28 14:46 [PATCH] amd74xx: implement suspend-to-ram Rafael J. Wysocki
2006-07-28 16:51 ` Alan Cox
2006-07-28 17:13 ` Jason Lunz [this message]
2006-07-28 19:16 ` Brad Campbell
2006-07-28 20:00 ` Alan Cox
2006-08-01 7:18 ` Benjamin Herrenschmidt
2006-07-29 23:34 ` [patch, rft] ide: reprogram disk pio timings on resume Jason Lunz
2006-07-30 3:25 ` Brad Campbell
2006-07-30 17:26 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060728171357.GB17549@knob.reflex \
--to=lunz@falooley.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox