public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Muli Ben-Yehuda <muli@il.ibm.com>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: Andrew Morton <akpm@osdl.org>,
	trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h
Date: Fri, 28 Jul 2006 20:44:49 +0300	[thread overview]
Message-ID: <20060728174449.GA11046@rhun.ibm.com> (raw)
In-Reply-To: <200607280928.54306.eike-kernel@sf-tec.de>

On Fri, Jul 28, 2006 at 09:28:49AM +0200, Rolf Eike Beer wrote:

> We have BUG_ON() right for this, don't we?

Even better, we have valid_dma_direction() in x86-64. Care to move it
to generic code and update i386 to use it?

Cheers,
Muli



  parent reply	other threads:[~2006-07-28 17:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-28  7:28 [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h Rolf Eike Beer
2006-07-28  7:47 ` Andrew Morton
2006-08-05 11:37   ` Pavel Machek
2006-08-07  1:20     ` Adrian Bunk
2006-07-28 17:44 ` Muli Ben-Yehuda [this message]
2006-08-02 15:20   ` [PATCH] Move valid_dma_direction() from x86_64 to generic code Rolf Eike Beer
2006-08-02 18:55     ` Muli Ben-Yehuda
2006-08-03  6:25       ` Rolf Eike Beer
2006-08-03  7:23         ` Muli Ben-Yehuda
2006-08-03 21:10           ` IOMMU (Calgary) patches Duran, Leo
2006-08-03 21:25             ` Jon Mason
2006-08-03 21:35               ` Duran, Leo
2006-08-03 22:46             ` [discuss] " Andi Kleen
2006-08-02 15:22   ` [PATCH] Use valid_dma_direction() in include/asm-i386/dma-mapping.h Rolf Eike Beer
2006-08-02 18:56     ` Muli Ben-Yehuda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060728174449.GA11046@rhun.ibm.com \
    --to=muli@il.ibm.com \
    --cc=akpm@osdl.org \
    --cc=eike-kernel@sf-tec.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox