From: Andi Kleen <ak@suse.de>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [patch 1/5] Add comments to the PDA structure to annotate offsets
Date: Fri, 28 Jul 2006 20:41:38 +0200 [thread overview]
Message-ID: <200607282041.38506.ak@suse.de> (raw)
In-Reply-To: <1154102590.6416.11.camel@laptopd505.fenrus.org>
On Friday 28 July 2006 18:03, Arjan van de Ven wrote:
> Subject: [patch 1/5] Add comments to the PDA structure to annotate offsets
> From: Arjan van de Ven <arjan@linux.intel.com>
So why exactly do you think these numbers need to be documented?
If there is a reason there should be a comment in the code.
Nobody should use fixed numbers, but always get the current ones
from asm-offset
-Andi
> Change the comments in the pda structu
next prev parent reply other threads:[~2006-07-28 18:41 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1154102546.6416.9.camel@laptopd505.fenrus.org>
2006-07-28 16:03 ` [patch 1/5] Add comments to the PDA structure to annotate offsets Arjan van de Ven
2006-07-28 18:41 ` Andi Kleen [this message]
2006-07-28 18:43 ` Arjan van de Ven
2006-07-28 18:52 ` Andi Kleen
2006-07-28 18:57 ` Arjan van de Ven
2006-07-28 20:32 ` Arjan van de Ven
2006-07-28 16:03 ` [patch 2/5] Add the Kconfig option for the stackprotector feature Arjan van de Ven
2006-07-28 16:24 ` Daniel Walker
2006-07-28 16:27 ` Arjan van de Ven
2006-07-28 18:42 ` Andi Kleen
2006-07-28 18:49 ` Arjan van de Ven
2006-07-28 17:13 ` Paweł Sikora
2006-07-28 17:26 ` Arjan van de Ven
2006-07-28 17:56 ` Thierry Vignaud
2006-07-28 18:06 ` Paweł Sikora
2006-07-29 17:48 ` Adrian Bunk
2006-07-29 18:50 ` Andi Kleen
2006-07-29 18:57 ` Adrian Bunk
2006-07-29 19:04 ` Andi Kleen
2006-07-29 19:19 ` Adrian Bunk
2006-07-30 16:14 ` Valdis.Kletnieks
2006-07-30 16:49 ` Adrian Bunk
2006-07-31 2:06 ` Valdis.Kletnieks
2006-07-30 17:47 ` Arjan van de Ven
2006-07-28 16:04 ` [patch 3/5] Add the canary field to the PDA area and the task struct Arjan van de Ven
2006-07-28 16:05 ` [patch 4/5] Add the __stack_chk_fail() function Arjan van de Ven
2006-07-28 16:05 ` [patch 5/5] Add the -fstack-protector option to the CFLAGS Arjan van de Ven
2006-07-28 18:45 ` Andi Kleen
2006-07-28 18:48 ` Arjan van de Ven
2006-07-28 19:00 ` Andi Kleen
2006-07-28 19:53 ` Arjan van de Ven
2006-07-28 21:26 ` Sam Ravnborg
2006-07-28 21:40 ` Arjan van de Ven
2006-07-28 21:58 ` Sam Ravnborg
2006-07-28 22:31 ` Arjan van de Ven
2006-07-28 23:05 ` Valdis.Kletnieks
2006-07-28 23:12 ` David Miller
2006-07-28 23:51 ` Valdis.Kletnieks
2006-07-29 7:41 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607282041.38506.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox