Re: [patch 5/5] Add the -fstack-protector option to the CFLAGS

Andi Kleen
2006-07-28T18:59:34Z

On Friday 28 July 2006 20:48, Arjan van de Ven wrote:
> On Fri, 2006-07-28 at 20:45 +0200, Andi Kleen wrote:
> > > +ifdef CONFIG_CC_STACKPROTECTOR
> > > +CFLAGS += $(call cc-ifversion, -lt, 0402, -fno-stack-protector)
> > > +CFLAGS += $(call cc-ifversion, -ge, 0402, -fstack-protector)
> >
> > Why can't you just use the normal call cc-option for this?
>
> this requires gcc 4.2; cc-option is not useful for that.

This means nearly nobody can use it. The CC option thing is also
very ugly. Perhaps you really need a Makefile time check like
configure would do for it. Generating a .s and grepping for %gs
would be enough I guess.

-Andi