Re: [patch 2/5] Add the Kconfig option for the stackprotector feature

Adrian Bunk
2006-07-29T19:19:39Z

On Sat, Jul 29, 2006 at 09:04:18PM +0200, Andi Kleen wrote:
>
> > > It should be obsolete with autoprobing for the feature as earlier discussed.
> >
> > That's not the point of the version information in the help text.
>
> The point in the current option is to select or not select it -
> if the user gets it wrong it won't compile or worse miscompile.

That was never true in Arjan's patches.

The only change is from a gcc version check to a feature check.

In both cases, a gcc 4.1 without the appropriate patch applied will
result in this option not being set.

> Once it is auto selected the user could be still informed about
> it, but it doesn't matter much anymore (we don't inform the user
> about every possible trade off based on compiler version everywhere)

If an option might possible have zero effect, we do always inform the
user. If not, please tell me which options this are so we can fix them.

We don't inform users about internal compiler version dependent things
like -fno-unit-at-a-time on i386 with neither a config option nor any
user visible effect (except for kernel size and speed).

> -Andi

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed