Re: [patch 1/5] Add comments to the PDA structure to annotate offsets

Arjan van de Ven
2006-07-28T18:57:19Z

On Fri, 2006-07-28 at 20:52 +0200, Andi Kleen wrote:
> On Friday 28 July 2006 20:43, Arjan van de Ven wrote:
> > On Fri, 2006-07-28 at 20:41 +0200, Andi Kleen wrote:
> > > On Friday 28 July 2006 18:03, Arjan van de Ven wrote:
> > > > Subject: [patch 1/5] Add comments to the PDA structure to annotate
> > > > offsets From: Arjan van de Ven <arjan@linux.intel.com>
> > >
> > > So why exactly do you think these numbers need to be documented?
> > >
> > > If there is a reason there should be a comment in the code.
> > >
> > > Nobody should use fixed numbers, but always get the current ones
> > > from asm-offset
> >
> > the 40 one is a gcc ABI one (same offset as userland);
>
> Ah sounds ugly. Wasn't it possible to pass that as an option
> to gcc?

nope :(