From: Andrew Morton <akpm@osdl.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-kernel@vger.kernel.org, pavel@ucw.cz
Subject: Re: [PATCH -mm][resend] Disable CPU hotplug during suspend
Date: Fri, 28 Jul 2006 22:15:08 -0700 [thread overview]
Message-ID: <20060728221508.9ec9be23.akpm@osdl.org> (raw)
In-Reply-To: <200607281015.30048.rjw@sisk.pl>
On Fri, 28 Jul 2006 10:15:29 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> int disable_nonboot_cpus(void)
> +{
> + int cpu, error = 0;
> +
> + /* We take all of the non-boot CPUs down in one shot to avoid races
> + * with the userspace trying to use the CPU hotplug at the same time
> + */
> + mutex_lock(&cpu_add_remove_lock);
> + cpus_clear(frozen_cpus);
> + printk("Disabling non-boot CPUs ...\n");
> + for_each_online_cpu(cpu) {
> + if (cpu == 0)
> + continue;
This is presumably only called on cpu 0, yes?
How can we guarantee that, given that preemption is enabled?
What happens if cpu 0 isn't online?
next prev parent reply other threads:[~2006-07-29 5:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-28 8:15 [PATCH -mm][resend] Disable CPU hotplug during suspend Rafael J. Wysocki
2006-07-28 18:20 ` Nathan Lynch
2006-07-28 19:15 ` Rafael J. Wysocki
2006-07-28 21:23 ` Rafael J. Wysocki
2006-07-28 22:40 ` Nathan Lynch
2006-07-29 12:18 ` Rafael J. Wysocki
2006-07-29 21:40 ` Nathan Lynch
2006-07-29 23:07 ` Rafael J. Wysocki
2006-07-29 5:15 ` Andrew Morton [this message]
2006-07-29 12:27 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060728221508.9ec9be23.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox