From: Dave Jones <davej@redhat.com>
To: Andi Kleen <ak@suse.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] i386: Do backtrace fallback too
Date: Sat, 29 Jul 2006 13:13:18 -0400 [thread overview]
Message-ID: <20060729171318.GF16946@redhat.com> (raw)
In-Reply-To: <200607291903.10969.ak@suse.de>
On Sat, Jul 29, 2006 at 07:03:10PM +0200, Andi Kleen wrote:
>
> > > > print_symbol("DWARF2 unwinder stuck at %s\n",
> > > > UNW_PC(info.regs));
> > > >
> > > > be using %p ?
> > >
> > > Yes good catch.
> >
> > The x86-64 equivalent also has an instance of the same bug.
>
> Actually on double checking the %s is correct because it's print_symbol
Ah, of course. Somehow I missed that on two separate readings of the code.
Dave
--
http://www.codemonkey.org.uk
prev parent reply other threads:[~2006-07-29 17:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200607290300.k6T306Fc003168@hera.kernel.org>
2006-07-29 7:54 ` [PATCH] i386: Do backtrace fallback too Dave Jones
2006-07-29 10:28 ` Erik Mouw
2006-07-29 16:35 ` Andi Kleen
2006-07-29 16:42 ` Dave Jones
2006-07-29 16:52 ` Andi Kleen
2006-07-29 17:03 ` Andi Kleen
2006-07-29 17:13 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060729171318.GF16946@redhat.com \
--to=davej@redhat.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox