From: Andi Kleen <ak@suse.de>
To: kmannth@us.ibm.com
Cc: lkml <linux-kernel@vger.kernel.org>,
lhms-devel <lhms-devel@lists.sourceforge.net>,
discuss <discuss@x86-64.org>, andrew <akpm@osdl.org>,
dave hansen <haveblue@us.ibm.com>,
kame <kamezawa.hiroyu@jp.fujitsu.com>, konrad <darnok@us.ibm.com>
Subject: Re: [Patch] 1/5 in support of hot-add memory x86_64 nodes_add cleanup
Date: Sat, 29 Jul 2006 18:24:25 +0200 [thread overview]
Message-ID: <200607291824.25584.ak@suse.de> (raw)
In-Reply-To: <1154141535.5874.145.camel@keithlap>
If you add attachments (which are harder to review because they cannot be
quoted) put at least a copy of the description into the attachment and make
them inline.
One thing that's unclear to me is why you make the reserve hotadd Kconfig
user visible (and why put it into Kconfig at all). I don't think it should be
user visible.
Also most of the patch seems to be renaming a variable which seems somewhat
pointless?
-Andi
On Saturday 29 July 2006 04:52, keith mannthey wrote:
> This patch cleans up the srat.c file with respects to the 2 hot-add
> paths available. It creates Kconfig options to represent the desired
> functionality and implements their usage.
>
> The current code already saves the information need (NUMA locality of
> hot-add memory ranges) for MEMORY_HOTPLUG in the RESERVE_MEMORY path. I
> amend the memory parsing code to support the needs of both and save the
> nodes_add data for use at runtime.
>
> Built against 2.6.18-rc2
>
> Signed-off-by: Keith Mannthey <kmannth@us.ibm.com>
next prev parent reply other threads:[~2006-07-29 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-29 2:52 [Patch] 1/5 in support of hot-add memory x86_64 nodes_add cleanup keith mannthey
2006-07-29 16:24 ` Andi Kleen [this message]
2006-07-29 19:22 ` keith mannthey
2006-07-29 19:30 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607291824.25584.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=darnok@us.ibm.com \
--cc=discuss@x86-64.org \
--cc=haveblue@us.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kmannth@us.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox