From: Andrew Morton <akpm@osdl.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: nate.diller@gmail.com, ak@suse.de, torvalds@osdl.org,
discuss@x86-64.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH for 2.6.18] [8/8] MM: Remove rogue readahead printk
Date: Sat, 29 Jul 2006 23:26:25 -0700 [thread overview]
Message-ID: <20060729232625.c8bcac66.akpm@osdl.org> (raw)
In-Reply-To: <1154233334.5784.93.camel@localhost>
On Sun, 30 Jul 2006 00:22:14 -0400
Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> > of course, it could be that some quirk of the NFS client VFS interface
> > causes "spurious" -EIO returns. either way, i'd rather see it fixed
> > rather than the printk removed, since it is useful to point out that
> > some performance degradation is occuring.
>
> We have no way of telling. That printk doesn't give us any useful
> information whatsoever for debugging that sort of problem. It should
> either be replaced with something that does, or it should be thrown out.
err, the printk has found a probable bug in NFS. That was pretty useful
of it.
Do we know why nfs's readpage isn't bringing the page up to date?
next prev parent reply other threads:[~2006-07-30 6:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-29 19:42 [PATCH for 2.6.18] [8/8] MM: Remove rogue readahead printk Andi Kleen
2006-07-29 21:14 ` Trond Myklebust
2006-07-30 1:04 ` Nate Diller
2006-07-30 4:22 ` Trond Myklebust
2006-07-30 6:26 ` Andrew Morton [this message]
2006-07-30 16:12 ` Trond Myklebust
2006-07-30 16:48 ` [discuss] " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060729232625.c8bcac66.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nate.diller@gmail.com \
--cc=torvalds@osdl.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox