Re: [PATCH 00/12] making the kernel -Wshadow clean - The initial step

[Andrew Morton <akpm@osdl.org>]

On Sun, 30 Jul 2006 19:27:36 +0200
Krzysztof Halasa <khc@pm.waw.pl> wrote:

> "Jesper Juhl" <jesper.juhl@gmail.com> writes:
> 
> > I think it's a good thing that we have to take a little more care when
> > choosing global function and variable names... Take up() for example -
> > in my (very humble) oppinion that is a very bad name for a global
> > function - it clashes too easily with local function and variable
> > names, and a programmer who's not careful may end up calling the
> > global up() when he wants the local and vice versa (a much better name
> > would have been sem_up() - should we change that???).
> 
> Possibly, but it could then conflict with something else. Anytime we
> add/change some global symbol, we would have to scan entire kernel
> for conflicts (authors of (yet) off-tree things would hate us).

These things happen.  And it's only a warning.

> I don't think it's practical, especially with, IMHO, no real gain.

While I don't recall any kernel bugs which -Wshadow would have saved us
from, I think it's a sensible thing to do - it _might_ save us from a bug,
and we need all the help we can get.

Plus it's often the case that if a local and a global clash, one of the
identifiers was poorly chosen.