* [PATCH] intelfbhw.c: intelfbhw_get_p1p2 defined but not used
@ 2006-07-06 6:04 Parag Warudkar
2006-07-30 10:50 ` Jean Delvare
0 siblings, 1 reply; 3+ messages in thread
From: Parag Warudkar @ 2006-07-06 6:04 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds
[-- Attachment #1: Type: TEXT/PLAIN, Size: 163 bytes --]
intelfbhw_get_p1p2 is used only if REGDUMP is defined - compile it in only
if REGDUMP is defined - one less compiler warning.
Patch against 2.6.18-rc1.
Parag
[-- Attachment #2: intelfbhw.c.patch --]
[-- Type: TEXT/PLAIN, Size: 583 bytes --]
--- linux-2.6.17/drivers/video/intelfb/intelfbhw.c.orig 2006-07-06 01:48:55.000000000 -0400
+++ linux-2.6.17/drivers/video/intelfb/intelfbhw.c 2006-07-06 01:49:45.000000000 -0400
@@ -614,6 +614,7 @@ static int calc_vclock(int index, int m1
return vco / p;
}
+#if REGDUMP
static void
intelfbhw_get_p1p2(struct intelfb_info *dinfo, int dpll, int *o_p1, int *o_p2)
{
@@ -639,7 +640,7 @@ intelfbhw_get_p1p2(struct intelfb_info *
*o_p1 = p1;
*o_p2 = p2;
}
-
+#endif
void
intelfbhw_print_hw_state(struct intelfb_info *dinfo, struct intelfb_hwstate *hw)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] intelfbhw.c: intelfbhw_get_p1p2 defined but not used
2006-07-06 6:04 [PATCH] intelfbhw.c: intelfbhw_get_p1p2 defined but not used Parag Warudkar
@ 2006-07-30 10:50 ` Jean Delvare
2006-08-22 0:13 ` Dave Airlie
0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2006-07-30 10:50 UTC (permalink / raw)
To: Linus Torvalds, Sylvain Meyer
Cc: Parag Warudkar, linux-kernel, Antonino Daplas
> intelfbhw_get_p1p2 is used only if REGDUMP is defined - compile it in only
> if REGDUMP is defined - one less compiler warning.
>
> Patch against 2.6.18-rc1.
Can we please have this patch merged in Linus' tree now?
Thanks,
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] intelfbhw.c: intelfbhw_get_p1p2 defined but not used
2006-07-30 10:50 ` Jean Delvare
@ 2006-08-22 0:13 ` Dave Airlie
0 siblings, 0 replies; 3+ messages in thread
From: Dave Airlie @ 2006-08-22 0:13 UTC (permalink / raw)
To: Jean Delvare
Cc: Linus Torvalds, Sylvain Meyer, Parag Warudkar, linux-kernel,
Antonino Daplas
> >
> > Patch against 2.6.18-rc1.
>
> Can we please have this patch merged in Linus' tree now?
>
I've put this in my intelfb tree....
Dave.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-08-22 0:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-06 6:04 [PATCH] intelfbhw.c: intelfbhw_get_p1p2 defined but not used Parag Warudkar
2006-07-30 10:50 ` Jean Delvare
2006-08-22 0:13 ` Dave Airlie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox