Re: [PATCH 01/12] making the kernel -Wshadow clean - fix mconf

[Arnd Bergmann <arnd@arndb.de>]

Am Sunday 30 July 2006 20:48 schrieb Jesper Juhl:
> >     up
>
> I'd *love* to change this one - and down() as well - to up_sem() &
> down_sem(). But, making that change would be a pretty major and
> somewhat disruptive api change, so I opted instead to change the local
> variable names. I plan to introduce a sepperate patch set later on
> that adds up_sem()/down_sem() wrappers around up()/down(), deprecate
> the old names and add an entry to feature-removal.txt - but doing it
> now as part of the -Wshadow cleanup would be too much pain.

The path for getting rid of up()/down() is more along the lines
of replacing more semaphores with mutex variables. Once the only
users of up()/down() are those that really rely on counting semaphores,
it becomes much easier to do the change you proposed.

	Arnd <><