From: Ingo Molnar <mingo@elte.hu>
To: Paul Jackson <pj@sgi.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Simon.Derr@bull.net, Jack Steiner <steiner@sgi.com>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [BUG] sched: big numa dynamic sched domain memory corruption
Date: Mon, 31 Jul 2006 09:12:42 +0200 [thread overview]
Message-ID: <20060731071242.GA31377@elte.hu> (raw)
In-Reply-To: <20060731070734.19126.40501.sendpatchset@v0>
* Paul Jackson <pj@sgi.com> wrote:
> @@ -5675,12 +5675,13 @@ void build_sched_domains(const cpumask_t
> int group;
> struct sched_domain *sd = NULL, *p;
> cpumask_t nodemask = node_to_cpumask(cpu_to_node(i));
> + int cpus_per_node = cpus_weight(nodemask);
>
> cpus_and(nodemask, nodemask, *cpu_map);
>
> #ifdef CONFIG_NUMA
> - if (cpus_weight(*cpu_map)
> - > SD_NODES_PER_DOMAIN*cpus_weight(nodemask)) {
> + if (cpus_weight(cpu_online_map)
> + > SD_NODES_PER_DOMAIN*cpus_per_node) {
> if (!sched_group_allnodes) {
> sched_group_allnodes
> = kmalloc(sizeof(struct sched_group)
even if the bug is not fully understood in time, i think we should queue
the patch above for v2.6.18. (with the small nit that you should put the
new cpus_per_node variable under CONFIG_NUMA too, to avoid a compiler
warning)
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2006-07-31 7:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 7:07 [BUG] sched: big numa dynamic sched domain memory corruption Paul Jackson
2006-07-31 7:12 ` Ingo Molnar [this message]
2006-07-31 16:04 ` Siddha, Suresh B
2006-07-31 16:54 ` Paul Jackson
2006-07-31 17:15 ` Siddha, Suresh B
2006-08-02 6:57 ` Paul Jackson
2006-08-02 21:36 ` Siddha, Suresh B
2006-08-02 21:58 ` Paul Jackson
2006-08-06 1:38 ` Paul Jackson
2006-07-31 17:04 ` Paul Jackson
2006-08-01 8:25 ` Paul Jackson
2006-08-01 19:00 ` Siddha, Suresh B
2006-08-01 19:16 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060731071242.GA31377@elte.hu \
--to=mingo@elte.hu \
--cc=Simon.Derr@bull.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=pj@sgi.com \
--cc=steiner@sgi.com \
--cc=suresh.b.siddha@intel.com \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox