Re: [PATCH] OMAP: I2C driver for TI OMAP boards #2

David Brownell
2006-07-31T23:58:55Z

On Monday 31 July 2006 12:10 pm, Russell King wrote:
> On Mon, Jul 31, 2006 at 09:41:00AM -0700, David Brownell wrote:
> > On Monday 31 July 2006 9:13 am, Jean Delvare wrote:
> > > Hi David,
> > >
> > > > And I **really** hope this gets merged into 2.6.18 since virtually
> > > > no OMAP board is very usable without it. I2C is one of the main
> > > > missing pieces(*) ... can whoever's managing I2C merges please
> > > > expedite this?
>
> Slightly off-topic, and probably not your area, but it would probably
> help your case if omap were better looked after in mainline.

Actually that _is_ part of my case. It can't be looked after in any
reasonable way until the I2C driver gets merged, because significant
chunks of the OMAP driver stack require I2C. (And notably for me,
USB always requires I2C to handle VBUS switches ...)

So for example once the OMAP I2C gets merged, then it'll finallly
become practical for folk to try _using_ mainline kernels. Which
is a prerequisite for getting the bugs there fixed with any level
of promptness, since they can't be fixed until they're noticed.

> Most OMAP
> platforms build fine, except for one long standing one - the H2 1610
> defconfig, which hasn't built since 2.6.17-git11.

Yet oddly enough, that's the only OMAP defconfig present. :(

Once I2C gets merged, the OSK defconfig could be merged too; and
that's a much handier board to work with and test. H2 and OSK use
basically the same OMAP chip (5912 ~= 1610b), but 5912 doesn't need
NDAs; and the OSK board is is 10x smaller in size and price, plus
it's available on the open market.

> So, rather than shoveling new stuff in there, can the maintainence of
> the stuff already merged please be improved.
>
> Build results vs kernel version for H2 1610:
>
> http://armlinux.simtec.co.uk/kautobuild/omap_h2_1610_defconfig.html

You'll observe that I recently posted four build fixes (tps65010,
ohci-omap, omap-rng, smc91x) ... all of which would affect H2... the
fifth build fix will go to your armlinux patch database soon, it
addresses the fatal error in that build log. I've already submitted
patches for the three Kconfig complaints. (By the way, those build
logs could become more informative by using "make -k" ...)

Plus H2 is another of the OMAP platforms that can't be fully
initialized without using I2C. :)

- Dave