Re: [PATCH] OMAP: I2C driver for TI OMAP boards #2

Jean Delvare
2006-07-31T16:13:27Z

Hi David,

> And I **really** hope this gets merged into 2.6.18 since virtually
> no OMAP board is very usable without it. I2C is one of the main
> missing pieces(*) ... can whoever's managing I2C merges please
> expedite this?

It doesn't work like this, sorry. The merge window for 2.6.18 is
closed. The driver needs to be reviewed before it is merged. So the
best you can hope for is -mm soon, and 2.6.19.

> I just tried building an OSK config against RC3 and found at least
> five will-not-build errors in the kernel.org tree. The reason for
> this is basically that folk have no option except the linux-omap
> tree, since there's no point in trying to use the kernel.org version
> until the I2C driver finally gets merged ... so such bugs won't get
> fixed. Needless to say, this is not the desired development process.

Indeed, this is no good. If you want things to improve, please help by
reviewing Komal's driver. I think I understand you already commented on
it, but I'd like you to really review it, and add a formal approval to
it (e.g. Signed-off-by or Acked-by). Then I'll review it for merge.

> (*) I submitted the then-current I2C driver over a year ago, but
> after a few months of inaction I found that it was dropped
> (or rejected?) by the I2C list software. Of course at that
> point I no longer had time to resubmit the current code ...

Neither dropped nor rejected, as I received it and it shows in the
archive as well:
http://lists.lm-sensors.org/pipermail/lm-sensors/2005-August/013216.html
The reason why it was "ignored" is more likely a lack of time and/or
interest.

What is the relation between your "old" driver and the new one Komal is
submitting now? Evolution, or rewrite?

--
Jean Delvare