From: Andi Kleen <ak@suse.de>
To: Matt Mackall <mpm@selenic.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] x86_64 built-in command line
Date: Mon, 31 Jul 2006 22:07:58 +0200 [thread overview]
Message-ID: <200607312207.58999.ak@suse.de> (raw)
In-Reply-To: <20060731171442.GI6908@waste.org>
> +#ifdef CONFIG_CMDLINE_BOOL
> + strlcpy(saved_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> +#endif
I think I would prefer a strcat.
Also you should describe the exact behaviour (override/append) in Kconfig help.
-Andi
next prev parent reply other threads:[~2006-07-31 20:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 17:14 [PATCH] x86_64 built-in command line Matt Mackall
2006-07-31 17:46 ` linux-os (Dick Johnson)
2006-07-31 20:07 ` Andi Kleen [this message]
2006-07-31 20:41 ` H. Peter Anvin
2006-07-31 22:17 ` Andi Kleen
2006-08-01 1:43 ` Matt Mackall
2006-08-01 2:29 ` H. Peter Anvin
2006-08-01 2:33 ` H. Peter Anvin
2006-08-01 2:38 ` H. Peter Anvin
2006-08-01 2:41 ` Matt Mackall
2006-08-01 2:44 ` Andi Kleen
2006-08-01 2:46 ` H. Peter Anvin
2006-08-01 2:46 ` Andi Kleen
2006-08-01 2:46 ` H. Peter Anvin
2006-08-01 2:49 ` Andrew Morton
2006-08-01 1:06 ` Deepak Saxena
2006-08-01 1:18 ` Andi Kleen
2006-08-01 3:47 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607312207.58999.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox