From: Andrew Morton <akpm@osdl.org>
To: Olaf Hering <olh@suse.de>
Cc: benh@kernel.crashing.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix link error in atyfb with backlight disabled
Date: Mon, 31 Jul 2006 23:31:34 -0700 [thread overview]
Message-ID: <20060731233134.d7477be8.akpm@osdl.org> (raw)
In-Reply-To: <20060731185220.GA5127@suse.de>
On Mon, 31 Jul 2006 20:52:20 +0200
Olaf Hering <olh@suse.de> wrote:
>
> aty_bl_set_power is only defined if CONFIG_FB_ATY_BACKLIGHT is enabled.
>
> Signed-off-by: Olaf Hering <olh@suse.de>
>
> Index: linux-2.6.18-rc3/drivers/video/aty/atyfb_base.c
> ===================================================================
> --- linux-2.6.18-rc3.orig/drivers/video/aty/atyfb_base.c
> +++ linux-2.6.18-rc3/drivers/video/aty/atyfb_base.c
> @@ -2812,7 +2812,7 @@ static int atyfb_blank(int blank, struct
> if (par->lock_blank || par->asleep)
> return 0;
>
> -#ifdef CONFIG_PMAC_BACKLIGHT
> +#if defined(CONFIG_PMAC_BACKLIGHT) && defined(CONFIG_FB_ATY_BACKLIGHT)
> if (machine_is(powermac) && blank > FB_BLANK_NORMAL)
> aty_bl_set_power(info, FB_BLANK_POWERDOWN);
> #elif defined(CONFIG_FB_ATY_GENERIC_LCD)
> @@ -2844,7 +2844,7 @@ static int atyfb_blank(int blank, struct
> }
> aty_st_le32(CRTC_GEN_CNTL, gen_cntl, par);
>
> -#ifdef CONFIG_PMAC_BACKLIGHT
> +#if defined(CONFIG_PMAC_BACKLIGHT) && defined(CONFIG_FB_ATY_BACKLIGHT)
> if (machine_is(powermac) && blank <= FB_BLANK_NORMAL)
> aty_bl_set_power(info, FB_BLANK_UNBLANK);
> #elif defined(CONFIG_FB_ATY_GENERIC_LCD)
Linus merged a patch today (powermac-more-powermac-backlight-fixes.patch)
whcih changes all this stuff. Its changelog included a mysterious "More
Kconfig fixes".
So can you please see if current -git is indeed fixed?
Thanks.
next prev parent reply other threads:[~2006-08-01 6:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 18:52 [PATCH] fix link error in atyfb with backlight disabled Olaf Hering
2006-08-01 6:31 ` Andrew Morton [this message]
2006-08-01 7:36 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060731233134.d7477be8.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox