From: Andi Kleen <ak@suse.de>
To: Diego Calleja <diegocg@gmail.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] AUX_DEVICE_INFO is one byte long, use 'movb'
Date: Tue, 1 Aug 2006 01:50:40 +0200 [thread overview]
Message-ID: <200608010150.40529.ak@suse.de> (raw)
In-Reply-To: <20060801014727.603e25a4.diegocg@gmail.com>
On Tuesday 01 August 2006 01:47, Diego Calleja wrote:
> Bugzilla #6552 says:
>
> "In arch/i386/boot/setup.S, movw is used instead of movb for PS/2 mouse
> information, although it is unsigned char. This does not harm, because
> the jmp instruction overwritten by movw is used before executing movw,
> and never be used again"
>
> I've no idea if this is a real bug or how it gets fixed, so I'm submitting
> it for review instead of letting it die of boredom in bugzilla. Aditionally
> to i386, I've changed x86-64, which mirrors the same code.
>
> Credits to Yoshinori K. Okuji, who found the problem and suggested a fix.
Queued thanks.
-Andi
prev parent reply other threads:[~2006-07-31 23:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 23:47 [PATCH] AUX_DEVICE_INFO is one byte long, use 'movb' Diego Calleja
2006-07-31 23:50 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608010150.40529.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=diegocg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox