Re: [PATCH] x86_64 built-in command line

Andrew Morton
2006-08-01T02:49:22Z

On Mon, 31 Jul 2006 20:43:19 -0500
Matt Mackall <mpm@selenic.com> wrote:

> On Tue, Aug 01, 2006 at 12:17:00AM +0200, Andi Kleen wrote:
> > On Monday 31 July 2006 22:41, H. Peter Anvin wrote:
> > > Andi Kleen wrote:
> > > >
> > > >> +#ifdef CONFIG_CMDLINE_BOOL
> > > >> + strlcpy(saved_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> > > >> +#endif
> > > >
> > > > I think I would prefer a strcat.
> > > >
> > > > Also you should describe the exact behaviour (override/append) in Kconfig help.
> > > >
> > >
> > > In the i386 thread, Matt described having a firmware bootloader which
> > > passes bogus parameters. For that case, it would make sense to have a
> > > non-default CONFIG option to have override rather than conjoined (and I
> > > maintain that the built-in command line should be prepended.)
> >
> > Is that boot loader common? What's its name?
> > If not I would prefer that he keeps the one liner patch to deal
> > with that private.
> >
> > For generic semantics strcat (or possible prepend) is probably better.
>
> No, it doesn't work for numerous kernel options that can't be negated.

I think what I'm hearing is that we need three options: append, prepend or replace.